Fix djb2 case insensitive hash function#21787
Merged
KBaichoo merged 1 commit intoenvoyproxy:mainfrom Jun 21, 2022
Merged
Conversation
|
Hi @andre-rosa, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
851e94d to
cd34861
Compare
Member
|
@andre-rosa cool. Nice catch. But seems like you need to update the expectations for some test cases? [ RUN ] StringUtil.StringViewCaseInsensitiveHash
test/common/common/utility_test.cc:454: Failure
Expected equality of these values:
8972312556107145900U
Which is: 8972312556107145900
StringUtil::CaseInsensitiveHash()("hello world")
Which is: 13876786532495509697
Stack trace:
0x4ea0f1: Envoy::StringUtil_StringViewCaseInsensitiveHash_Test::TestBody()
0x9f58fc: testing::internal::HandleExceptionsInMethodIfSupported<>()
0x9f57bd: testing::Test::Run()
0x9f6747: testing::TestInfo::Run() |
cd34861 to
e5cf6dd
Compare
Signed-off-by: Andre Goddard Rosa <andre.goddard@gmail.com> Commit Message: Fix djb2 case insensitive hash function Additional Description: See http://www.cse.yorku.ca/~oz/hash.html Risk Level: N/A Testing: N/A Docs Changes: N/A Release Notes: N/A
e5cf6dd to
b71e45c
Compare
Amila-Rukshan
pushed a commit
to Amila-Rukshan/envoy
that referenced
this pull request
Jun 28, 2022
Signed-off-by: Andre Goddard Rosa <andre.goddard@gmail.com> Commit Message: Fix djb2 case insensitive hash function Additional Description: See http://www.cse.yorku.ca/~oz/hash.html Risk Level: N/A Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Fix djb2 case insensitive hash function
Additional Description: See http://www.cse.yorku.ca/~oz/hash.html
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Commit Message: Fix djb2 case insensitive hash function
Additional Description: See http://www.cse.yorku.ca/~oz/hash.html
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]