proto_format: Shift proto_sync to bazel#21754
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Jun 17, 2022
Merged
Conversation
proto_format to bazelproto_format to bazel
proto_format to bazelproto_sync to bazel
df86caf to
cacdb7b
Compare
a37f43a to
9153bc2
Compare
Member
Author
9153bc2 to
d9f414e
Compare
proto_sync to bazelproto_sync to bazel
phlax
commented
Jun 17, 2022
Member
Author
|
better failing run with no other errors https://dev.azure.com/cncf/envoy/_build/results?buildId=110832&view=logs&j=55bc2ab9-36c1-5ab8-58a6-8c258728eeff&t=33b57bf9-ef13-58c8-bc2b-f804aeb16d39&l=589 |
12756a1 to
099c82c
Compare
099c82c to
a4418dc
Compare
proto_sync to bazelproto_sync to bazel
Member
Author
|
needs descriptor path |
a4418dc to
f975b78
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
f975b78 to
e7a5c32
Compare
keith
approved these changes
Jun 17, 2022
htuch
approved these changes
Jun 17, 2022
Amila-Rukshan
pushed a commit
to Amila-Rukshan/envoy
that referenced
this pull request
Jun 28, 2022
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
This doesnt resolve the performance issues with proto_format/sync but is the first step, bringing these into bazel will allow performance to be addressed subsequently.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]