Cors: add PNA support by daixiang0 · Pull Request #21581 · envoyproxy/envoy

daixiang0 · 2022-06-06T00:50:05Z

Add a PNA header check refer to https://developer.chrome.com/blog/private-network-access-preflight/.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA] #21553
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Loong Dai <loong.dai@intel.com>

repokitteh-read-only · 2022-06-06T00:50:15Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #21581 was opened by daixiang0.

see: more, trace.

Signed-off-by: Loong Dai <loong.dai@intel.com>

daixiang0 · 2022-06-06T02:37:20Z

Since changes are related to v2 API, switch to runtime guard for now.

Signed-off-by: Loong Dai <loong.dai@intel.com>

daixiang0 · 2022-06-08T05:43:17Z

kindly ping @adisuissa

wbpcode

Thanks for you contributions. Some comments are added. And I think may be we should add a new API in the envoy.config.route.v3.CorsPolicy, right?

source/extensions/filters/http/cors/cors_filter.h

source/extensions/filters/http/cors/cors_filter.cc

wbpcode · 2022-06-08T06:18:35Z

/assign

adisuissa

Not sure I grok the intention behind this feature, but it seems to address what's described in: https://developer.chrome.com/blog/private-network-access-preflight/

Probably no need for guarding it behind a runtime-flag.

source/extensions/filters/http/cors/cors_filter.cc

changelogs/current.yaml

Signed-off-by: Loong Dai <loong.dai@intel.com>

source/common/runtime/runtime_features.cc

source/common/router/config_impl.cc

api/envoy/config/route/v3/route_components.proto

Signed-off-by: Loong Dai <loong.dai@intel.com>

daixiang0 · 2022-06-21T00:37:08Z

Also please remove v2-freeze label, now it is unrelated.

daixiang0 · 2022-06-23T06:33:47Z

/retest for CI timeout.

repokitteh-read-only · 2022-06-23T06:33:52Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21581 (comment) was created by @daixiang0.

see: more, trace.

daixiang0 · 2022-07-04T01:28:20Z

@adisuissa friendly ping

wrowe · 2022-07-07T16:43:42Z

@adisuissa and @wbpcode, ping for when you are able (with all consideration for US holiday and pto, final approval may still be a bit delayed).

test/common/router/config_impl_test.cc

wbpcode

LGTM with nit comment. Thanks.

Signed-off-by: Loong Dai <loong.dai@intel.com>

daixiang0 · 2022-07-25T02:07:39Z

/retest

repokitteh-read-only · 2022-07-25T02:07:44Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21581 (comment) was created by @daixiang0.

see: more, trace.

daixiang0 · 2022-07-25T02:25:10Z

@phlax can we enable debug in verify step? The log is not helpful enough, I am not sure it is a network issue.

Signed-off-by: Loong Dai <loong.dai@intel.com>

wbpcode · 2022-07-26T02:24:07Z

/retest

repokitteh-read-only · 2022-07-26T02:24:12Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21581 (comment) was created by @wbpcode.

see: more, trace.

daixiang0 · 2022-07-28T01:22:59Z

@envoyproxy/api-shepherd for anther look. Thank you!

wbpcode · 2022-07-28T01:45:10Z

/assign-from @envoyproxy/api-shepherds

adisuissa

Apologies for dropping the ball on this.
/lgtm api
Will defer to @wbpcode for feature usage correctness.

daixiang0 · 2022-07-29T00:43:10Z

@wbpcode @adisuissa please review again, and remove "v2-freeze" label which is misleading.

source/common/router/config_impl.cc

wbpcode · 2022-07-29T01:54:22Z

/wait

Signed-off-by: Loong Dai <loong.dai@intel.com>

daixiang0 · 2022-08-01T02:38:27Z

kindly ping @wbpcode

wbpcode

LGTM. Thanks.

cors: add PNA support

ed2d689

Signed-off-by: Loong Dai <loong.dai@intel.com>

daixiang0 requested review from mattklein123 and wbpcode as code owners June 6, 2022 00:50

repokitteh-read-only bot added v2-freeze api labels Jun 6, 2022

repokitteh-read-only bot assigned adisuissa Jun 6, 2022

fix field

d96dea3

Signed-off-by: Loong Dai <loong.dai@intel.com>

daixiang0 added 4 commits June 6, 2022 10:42

use runtime guard rather than api change

0989a05

Signed-off-by: Loong Dai <loong.dai@intel.com>

fix CI

0c820af

Signed-off-by: Loong Dai <loong.dai@intel.com>

update changelog

08e2e91

Signed-off-by: Loong Dai <loong.dai@intel.com>

revert unrelated changes

a881ac0

Signed-off-by: Loong Dai <loong.dai@intel.com>

wbpcode requested changes Jun 8, 2022

View reviewed changes

source/extensions/filters/http/cors/cors_filter.h Show resolved Hide resolved

source/extensions/filters/http/cors/cors_filter.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot assigned wbpcode Jun 8, 2022

adisuissa reviewed Jun 8, 2022

View reviewed changes

source/extensions/filters/http/cors/cors_filter.cc Outdated Show resolved Hide resolved

source/extensions/filters/http/cors/cors_filter.cc Outdated Show resolved Hide resolved

changelogs/current.yaml Outdated Show resolved Hide resolved

daixiang0 added 2 commits June 9, 2022 15:08

update API

83c5012

Signed-off-by: Loong Dai <loong.dai@intel.com>

Merge branch 'main' into cors

b019156

adisuissa reviewed Jun 17, 2022

View reviewed changes

source/common/runtime/runtime_features.cc Outdated Show resolved Hide resolved

source/common/router/config_impl.cc Show resolved Hide resolved

api/envoy/config/route/v3/route_components.proto Show resolved Hide resolved

daixiang0 added 2 commits June 20, 2022 09:07

Merge branch 'main' into cors

be6060b

feedback and update tests

c320183

Signed-off-by: Loong Dai <loong.dai@intel.com>

Merge branch 'main' into cors

6a104e0

Merge branch 'main' into cors

f331d91

wbpcode reviewed Jul 22, 2022

View reviewed changes

test/common/router/config_impl_test.cc Outdated Show resolved Hide resolved

wbpcode previously approved these changes Jul 22, 2022

View reviewed changes

daixiang0 added 2 commits July 22, 2022 21:25

add tests

1528816

Signed-off-by: Loong Dai <loong.dai@intel.com>

feedback

87852fe

Signed-off-by: Loong Dai <loong.dai@intel.com>

daixiang0 dismissed wbpcode’s stale review via f5a9857 July 25, 2022 00:54

remove useless test

f5a9857

Signed-off-by: Loong Dai <loong.dai@intel.com>

adisuissa reviewed Jul 28, 2022

View reviewed changes

repokitteh-read-only bot removed the api label Jul 28, 2022

wbpcode removed the v2-freeze label Jul 29, 2022

wbpcode reviewed Jul 29, 2022

View reviewed changes

source/common/router/config_impl.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added waiting and removed waiting labels Jul 29, 2022

daixiang0 added 2 commits July 29, 2022 17:49

feedback

52b2aff

Signed-off-by: Loong Dai <loong.dai@intel.com>

fix CI

996e2a1

Signed-off-by: Loong Dai <loong.dai@intel.com>

wbpcode approved these changes Aug 1, 2022

View reviewed changes

wbpcode merged commit bf61b07 into envoyproxy:main Aug 1, 2022

daixiang0 deleted the cors branch August 1, 2022 02:58

gaby mentioned this pull request Mar 14, 2024

feat(middleware/cors): Add support for Access-Control-Allow-Private-Network gofiber/fiber#2908

Merged

12 tasks

Conversation

daixiang0 commented Jun 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Jun 6, 2022

Uh oh!

daixiang0 commented Jun 6, 2022

Uh oh!

daixiang0 commented Jun 8, 2022

Uh oh!

wbpcode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wbpcode commented Jun 8, 2022

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daixiang0 commented Jun 21, 2022

Uh oh!

daixiang0 commented Jun 23, 2022

Uh oh!

repokitteh-read-only bot commented Jun 23, 2022

Uh oh!

daixiang0 commented Jul 4, 2022

Uh oh!

wrowe commented Jul 7, 2022

Uh oh!

Uh oh!

wbpcode left a comment

Choose a reason for hiding this comment

Uh oh!

daixiang0 commented Jul 25, 2022

Uh oh!

repokitteh-read-only bot commented Jul 25, 2022

Uh oh!

daixiang0 commented Jul 25, 2022

Uh oh!

wbpcode commented Jul 26, 2022

Uh oh!

repokitteh-read-only bot commented Jul 26, 2022

Uh oh!

daixiang0 commented Jul 28, 2022

Uh oh!

wbpcode commented Jul 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

daixiang0 commented Jul 29, 2022

Uh oh!

Uh oh!

wbpcode commented Jul 29, 2022

Uh oh!

daixiang0 commented Aug 1, 2022

Uh oh!

wbpcode left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

daixiang0 commented Jun 6, 2022 •

edited

Loading

wbpcode commented Jul 28, 2022 •

edited

Loading