tag extraction: remove duplicate names for response code class metrics#2147
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Dec 2, 2017
Merged
tag extraction: remove duplicate names for response code class metrics#2147mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Matt Rice <mattrice@google.com>
Member
Author
Signed-off-by: Matt Rice <mattrice@google.com>
mattklein123
approved these changes
Dec 2, 2017
Member
mattklein123
left a comment
There was a problem hiding this comment.
This is great. Thanks @mrice32
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* update envoy with latest build fixes Signed-off-by: Lizan Zhou <lizan@tetrate.io> * update protobuf to match envoy Signed-off-by: Lizan Zhou <lizan@tetrate.io> * timeSystem -> timeSource Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* update envoy to latest Signed-off-by: Lizan Zhou <lizan@tetrate.io> * update envoy with latest build fixes (envoyproxy#2147) * fix build Signed-off-by: Lizan Zhou <lizan@tetrate.io> * fix build Signed-off-by: Lizan Zhou <lizan@tetrate.io> * fix formatting * fix status match Signed-off-by: Lizan Zhou <lizan@tetrate.io>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
All stats that end with
*rq_5xxand*rq_500(for example) were being mapped to the sametag_extracted_name:*rq, which is expected to be a unique identifier for a particular stat in order for downstream systems to take advantage of tag extraction. Since two logical stats were being collapsed to the same name, this uniqueness was violated (see #2141 for details). This change updates the mapped name and tag value of the*rq_5xxcase. The tag value becomes5rather than5xxand thetag_extracted_namebecomes*rq_xx(these choices are due to the current limitations of the regex extraction system).Future work: add some complexity to the tag extraction regex system to allow the user to inject strings that are not present in the canonical string name into the
tag_extracted_name. However, this fix should be good for differentiating these two sets of stats for the time being.Fixes #2141
Risk Level: Low
Testing:
Updated existing tag extraction tests to ensure that updated regexes work as expected.