skywalking: set peer with tag value of peer.address#21137
Merged
lizan merged 4 commits intoenvoyproxy:mainfrom May 4, 2022
Merged
skywalking: set peer with tag value of peer.address#21137lizan merged 4 commits intoenvoyproxy:mainfrom
lizan merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Member
Author
Member
Author
|
@Shikugawa is busy now. Could you take a look when you have free time? cc @lizan Thanks. 😄 |
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
Thanks for helping. |
jcchavezs
reviewed
May 4, 2022
Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
lizan
approved these changes
May 4, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Peer is a important attribution of skywalking span. But in the previous skywalking tracer's implementation, it never be set correctly. This PR will set peer of skywalking span with that tag value of `peer.address`. This PR consist of two part: 1. Set `peer.address` tag when we calling the `finalizeUpstreamSpan`. 2. Set peer of skywalking span base on the value of `peer.address` tag. Risk Level: Low. Testing: Added Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. Signed-off-by: wbpcode <wangbaiping@corp.netease.com> Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wbpcode wangbaiping@corp.netease.com
Commit Message: skywalking: set peer with tag value of peer.address
Additional Description:
Peer is a important attribution of skywalking span. But in the previous skywalking tracer's implementation, it never be set correctly. This PR will set peer of skywalking span with that tag value of
peer.address.This PR consist of two part:
peer.addresstag when we calling thefinalizeUpstreamSpan.peer.addresstag.Risk Level: Low.
Testing: Added
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.