http/2: extend keep alive timeout when frame is received#21077
Merged
mattklein123 merged 3 commits intomainfrom Apr 29, 2022
Merged
http/2: extend keep alive timeout when frame is received#21077mattklein123 merged 3 commits intomainfrom
mattklein123 merged 3 commits intomainfrom
Conversation
To avoid HOL blocking impacts on slow connections. Signed-off-by: Matt Klein <mklein@lyft.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Matt Klein <mklein@lyft.com>
RyanTheOptimist
previously approved these changes
Apr 28, 2022
| // amount of time. To avoid HOL blocking influence, if we receive *any* frame extend the | ||
| // timeout for another timeout period. This will still timeout the connection if there is no | ||
| // activity, but if there is frame activity we assume the connection is still healthy and the | ||
| // PING ACK may be delayed behind other frames. |
Contributor
|
Looks like the spell checker doesn't like "HOL"? |
Contributor
... which you just fixed. LOL. |
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
5 tasks
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…21077) To avoid HOL blocking impacts on slow connections. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid HOL blocking impacts on slow connections.
Risk Level: Low
Testing: New UTs
Docs Changes: Added
Release Notes: Added
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.http2_delay_keepalive_timeout