cds: allow v1 config to define api_type in the json-schema#2094
Merged
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
@envoyproxy/maintainers |
htuch
approved these changes
Nov 22, 2017
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
sha256sum shouldn't be necessary, since we use gsha256sum on macOS. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Also cleans up some of the pgv hackery Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Also cleans up some of the pgv hackery Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cds: allow v1 config to define api_type in the json-schema
Description: #1583 enabled v1 bootstrap configs to define the api type of the management server. This PR adds that constraint to the CDS definition schema.
Risk Level: Low
Testing: existing utility tests test the translation; existing tests test that a v2 grpc cds server can be used.