api: Add validate to required member.#20881
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Apr 19, 2022
Merged
Conversation
ComparisonFilter's value now marked as required in validate to ensure valid input to fuzz tests. Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
Author
|
@adisuissa, @yanavlasov, @htuch Here is the patch as requested. |
adisuissa
approved these changes
Apr 19, 2022
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
LGTM.
This is a breaking change to the API!
That said looking at the ComparisonFilter type, it doesn't make sense to only have op without the value, so I think it makes sense
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
ComparisonFilter's value now marked as required in validate to ensure valid input to fuzz tests. Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: api: Add validate to required member.
Additional Description:
ComparisonFilter's value now marked as required in validate to ensure valid
input to fuzz tests.
Signed-off-by: Andre Vehreschild vehre@x41-dsec.de
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
API Considerations: Add a validate rule to the value a binary operation compares against. Not ensuring that the value exists without giving a reasonable default is questionable. Therefore this patch adds a validate rule to at least flag the missing value.