uhv: add http-parser permissive parsing for h1 codec#20872
Merged
snowp merged 6 commits intoenvoyproxy:mainfrom Apr 29, 2022
Merged
uhv: add http-parser permissive parsing for h1 codec#20872snowp merged 6 commits intoenvoyproxy:mainfrom
snowp merged 6 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Contributor
Author
|
@yanavlasov This should be good for review. |
yanavlasov
approved these changes
Apr 21, 2022
Contributor
|
@alyssawilk this is special UHV build for H/1 parser with header validation disabled, using existing #define |
alyssawilk
reviewed
Apr 25, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Yeah this has my thumbs up, assuming it fails the compile time build without that early return. Mind taking that define out and checking once?
/wait
Contributor
Author
|
@alyssawilk I have confirmed that removing the early |
alyssawilk
approved these changes
Apr 26, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Awesome, thanks for confirming.
cc @snowp for !Googler pass
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: uhv: add http-parser permissive parsing for h1 codec
Additional Description: Honor the new
uhv_enabledbuild flag to disable strict parsing within the H1 parsing library (http-parser). This is a reworking of the previous PR, #20528, but this time using the new compile-time option instead of making it configurable at runtime.Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes #19750