ext_proc: Support per-route GrpcService configuration.#20757
ext_proc: Support per-route GrpcService configuration.#20757htuch merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Michael Warres <mpw@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
Requesting review from ext_proc owners. /assign @chaoqin-li1123 @pradeepcrao |
htuch
left a comment
There was a problem hiding this comment.
How much scalability in # services do you need? I don't think this is going to be any different than regular Envoy cluster or gRPC client scalability concerns, but worth keeping in mind if you have many different services across routes.
As discussed offline, we don't anticipate a large number of services in the near term, and will look to other approaches to address future scaling, such as having ExtProc set metadata based on per-route config that could then be read and acted upon by a (single) grpc_service's upstream filter. |
| } | ||
|
|
||
| void processAndRespondImmediately(bool first_message, | ||
| void processAndRespondImmediately(FakeUpstream& grpc_upstream, bool first_message, |
There was a problem hiding this comment.
Nit: do you think organizing these gRPC upstream methods inside a class would make sense?
There was a problem hiding this comment.
Yes, I think that would be cleaner, and allow for more flexible tests in the future with separate processor_connection_ and processor_stream_ for each FakeExternalProcessor.
I'd prefer to do that in a follow-on PR, though, to delineate the test refactor from the behavior additions in this PR.
Signed-off-by: Michael Warres <mpw@google.com>
|
@snowp PTAL when you get a chance, thanks. |
snowp
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
|
Needs main merge /wait |
Signed-off-by: Michael Warres <mpw@google.com>
|
Thanks for the reviews! Have merged from main. |
) This adds the ability to change the GrpcService used by the ext_proc filter on a per-route basis. Risk Level: Low. Not triggered unless configured. Testing: New unit and integration tests added. Docs Changes: Addition of new config field. Signed-off-by: Michael Warres <mpw@google.com> Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
This adds the ability to change the GrpcService used by the ext_proc filter on a per-route basis.
Signed-off-by: Michael Warres mpw@google.com
Commit Message: ext_proc: Support per-route GrpcService configuration
Additional Description:
Risk Level: Low. Not triggered unless configured.
Testing: New unit and integration tests added.
Docs Changes: Addition of new config field.
Release Notes:
Platform Specific Features: