Skip to content

Update QUICHE from bac04054b to 8864d08f6#20747

Merged
RyanTheOptimist merged 6 commits intoenvoyproxy:mainfrom
RyanTheOptimist:quiche-roll-20220408231432
Apr 12, 2022
Merged

Update QUICHE from bac04054b to 8864d08f6#20747
RyanTheOptimist merged 6 commits intoenvoyproxy:mainfrom
RyanTheOptimist:quiche-roll-20220408231432

Conversation

@RyanTheOptimist
Copy link
Copy Markdown
Contributor

@RyanTheOptimist RyanTheOptimist commented Apr 8, 2022 •
edited
Loading

Update QUICHE from bac04054b to 8864d08f6
https://github.com/google/quiche/compare/bac04054b..8864d08f6

$ git log bac04054b..8864d08f6 --date=short --no-merges --format="%ad %al %s"

2022-04-11 diannahu Fix the receipt of GOAWAYs as the server in oghttp2.
2022-04-11 danzh Automated g4 rollback of changelist 437128224.
2022-04-11 bnc Platformize enforcing header policy in Balsa.
2022-04-11 vasilvv Use relative include paths for OpenSSL and zlib in QUICHE.
2022-04-11 diannahu Handle new/pending streams on receipt of a GOAWAY in oghttp2.
2022-04-11 bnc Fix header guards in QUICHE.
2022-04-11 wub Deprecate --gfe2_reloadable_flag_quic_tls_no_select_cert_if_disconnected.
2022-04-11 fayang Internal change
2022-04-08 rch Make QUICHE pragmas which disable warnings google3-specific.
2022-04-08 haoyuewang Remove connection_option RVCM such that IETF QUIC connection migration is default on.
2022-04-08 wub Change QuicPathChallengeFrame and QuicPathResponseFrame to be inlined quic frame.
2022-04-07 diannahu Update oghttp2 to close streams above a received GOAWAY's last_stream_id.
2022-04-07 renjietang Change default path degrading delay to 4PTOs when PTO is enabled.
2022-04-07 martinduke Minor cleanup of the QUIC-LB library. Take review comments from late in the process and apply them to earlier classes.
2022-04-07 quiche-dev Internal change

Signed-off-by: Ryan Hamilton rch@google.com

@RyanTheOptimist
Update QUICHE from bac04054b to 7f718d04e
0936acd 
https://github.com/google/quiche/compare/bac04054b..7f718d04e

$ git log bac04054b..7f718d04e --date=short --no-merges --format="%ad %al %s"

2022-04-08 rch Make QUICHE pragmas which disable warnings google3-specific.
2022-04-08 haoyuewang Remove connection_option RVCM such that IETF QUIC connection migration is default on.
2022-04-08 wub Change QuicPathChallengeFrame and QuicPathResponseFrame to be inlined quic frame.
2022-04-07 diannahu Update oghttp2 to close streams above a received GOAWAY's last_stream_id.
2022-04-07 renjietang Change default path degrading delay to 4PTOs when PTO is enabled.
2022-04-07 martinduke Minor cleanup of the QUIC-LB library. Take review comments from late in the process and apply them to earlier classes.
2022-04-07 quiche-dev Internal change

Signed-off-by: Ryan Hamilton <rch@google.com>
@RyanTheOptimist
No longer transform QUICHE pragmas
8bb09d8 
Signed-off-by: Ryan Hamilton <rch@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 8, 2022
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Apr 8, 2022

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #20747 was opened by RyanTheOptimist.

see: more, trace.

@RyanTheOptimist
Copy link
Copy Markdown
Contributor Author

RyanTheOptimist commented Apr 8, 2022

/assign @danzh2010

danzh2010
danzh2010 previously approved these changes Apr 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@danzh2010 danzh2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bazel/repositories.bzl
/^#include/ s!third_party/boringssl/src/include/!! ;\
/^#include/ s!third_party/nghttp2/src/lib/includes/!! ;\
/^#include/ s!third_party/zlib/!! ;\
/^#pragma/ s!clang!GCC!; \
Copy link
Copy Markdown
Contributor

@danzh2010 danzh2010 Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Copy Markdown
Contributor Author

@RyanTheOptimist RyanTheOptimist Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And with another round of fixes, this is completely gone now!

@danzh2010
Copy link
Copy Markdown
Contributor

danzh2010 commented Apr 11, 2022

HTTP/2 test failed. Maybe related to google/quiche@9af10d5 @diannahu

@RyanTheOptimist
Copy link
Copy Markdown
Contributor Author

RyanTheOptimist commented Apr 11, 2022

HTTP/2 test failed. Maybe related to google/quiche@9af10d5 @diannahu

Thanks! Yes, indeed. @diannahu is working on a fix.

@RyanTheOptimist
Update QUICHE from bac04054b to daa2fda8d
95654f7 
https://github.com/google/quiche/compare/bac04054b..daa2fda8d

$ git log bac04054b..daa2fda8d --date=short --no-merges --format="%ad %al %s"

2022-04-11 vasilvv Use relative include paths for OpenSSL and zlib in QUICHE.
2022-04-11 diannahu Handle new/pending streams on receipt of a GOAWAY in oghttp2.
2022-04-11 bnc Fix header guards in QUICHE.
2022-04-11 wub Deprecate --gfe2_reloadable_flag_quic_tls_no_select_cert_if_disconnected.
2022-04-11 fayang Internal change
2022-04-08 rch Make QUICHE pragmas which disable warnings google3-specific.
2022-04-08 haoyuewang Remove connection_option RVCM such that IETF QUIC connection migration is default on.
2022-04-08 wub Change QuicPathChallengeFrame and QuicPathResponseFrame to be inlined quic frame.
2022-04-07 diannahu Update oghttp2 to close streams above a received GOAWAY's last_stream_id.
2022-04-07 renjietang Change default path degrading delay to 4PTOs when PTO is enabled.
2022-04-07 martinduke Minor cleanup of the QUIC-LB library. Take review comments from late in the process and apply them to earlier classes.
2022-04-07 quiche-dev Internal change

Signed-off-by: Ryan Hamilton <rch@google.com>
@RyanTheOptimist
Remove QUICHE Patches!
5881c7c 
Signed-off-by: Ryan Hamilton <rch@google.com>
@RyanTheOptimist
Update QUICHE from bac04054b to 8760571f6
9119206 
https://github.com/google/quiche/compare/bac04054b..8760571f6

$ git log bac04054b..8760571f6 --date=short --no-merges --format="%ad %al %s"

2022-04-11 danzh Automated g4 rollback of changelist 437128224.
2022-04-11 bnc Platformize enforcing header policy in Balsa.
2022-04-11 vasilvv Use relative include paths for OpenSSL and zlib in QUICHE.
2022-04-11 diannahu Handle new/pending streams on receipt of a GOAWAY in oghttp2.
2022-04-11 bnc Fix header guards in QUICHE.
2022-04-11 wub Deprecate --gfe2_reloadable_flag_quic_tls_no_select_cert_if_disconnected.
2022-04-11 fayang Internal change
2022-04-08 rch Make QUICHE pragmas which disable warnings google3-specific.
2022-04-08 haoyuewang Remove connection_option RVCM such that IETF QUIC connection migration is default on.
2022-04-08 wub Change QuicPathChallengeFrame and QuicPathResponseFrame to be inlined quic frame.
2022-04-07 diannahu Update oghttp2 to close streams above a received GOAWAY's last_stream_id.
2022-04-07 renjietang Change default path degrading delay to 4PTOs when PTO is enabled.
2022-04-07 martinduke Minor cleanup of the QUIC-LB library. Take review comments from late in the process and apply them to earlier classes.
2022-04-07 quiche-dev Internal change

Signed-off-by: Ryan Hamilton <rch@google.com>
@diannahu
Copy link
Copy Markdown
Contributor

diannahu commented Apr 11, 2022

Thanks @danzh2010 and @RyanTheOptimist! Fix just landed in the Googs.

@RyanTheOptimist RyanTheOptimist changed the title Update QUICHE from bac04054b to 7f718d04e Update QUICHE from bac04054b to 8760571f6 Apr 11, 2022
@RyanTheOptimist
Copy link
Copy Markdown
Contributor Author

RyanTheOptimist commented Apr 11, 2022

Thanks @danzh2010 and @RyanTheOptimist! Fix just landed in the Googs.

Thanks so much. I've merged this in and it's passing locally. Now to wait for CI :)

@RyanTheOptimist
Update QUICHE from bac04054b to 8864d08f6
d4edf9d 
https://github.com/google/quiche/compare/bac04054b..8864d08f6

$ git log bac04054b..8864d08f6 --date=short --no-merges --format="%ad %al %s"

2022-04-11 diannahu Fix the receipt of GOAWAYs as the server in oghttp2.
2022-04-11 danzh Automated g4 rollback of changelist 437128224.
2022-04-11 bnc Platformize enforcing header policy in Balsa.
2022-04-11 vasilvv Use relative include paths for OpenSSL and zlib in QUICHE.
2022-04-11 diannahu Handle new/pending streams on receipt of a GOAWAY in oghttp2.
2022-04-11 bnc Fix header guards in QUICHE.
2022-04-11 wub Deprecate --gfe2_reloadable_flag_quic_tls_no_select_cert_if_disconnected.
2022-04-11 fayang Internal change
2022-04-08 rch Make QUICHE pragmas which disable warnings google3-specific.
2022-04-08 haoyuewang Remove connection_option RVCM such that IETF QUIC connection migration is default on.
2022-04-08 wub Change QuicPathChallengeFrame and QuicPathResponseFrame to be inlined quic frame.
2022-04-07 diannahu Update oghttp2 to close streams above a received GOAWAY's last_stream_id.
2022-04-07 renjietang Change default path degrading delay to 4PTOs when PTO is enabled.
2022-04-07 martinduke Minor cleanup of the QUIC-LB library. Take review comments from late in the process and apply them to earlier classes.
2022-04-07 quiche-dev Internal change

Signed-off-by: Ryan Hamilton <rch@google.com>
@RyanTheOptimist RyanTheOptimist changed the title Update QUICHE from bac04054b to 8760571f6 Update QUICHE from bac04054b to 8864d08f6 Apr 11, 2022
@RyanTheOptimist
Copy link
Copy Markdown
Contributor Author

RyanTheOptimist commented Apr 12, 2022

Ok, this is all green now. @mattklein123, PTAL

@moderation
Copy link
Copy Markdown
Contributor

moderation commented Apr 12, 2022

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Apr 12, 2022
@RyanTheOptimist RyanTheOptimist enabled auto-merge (squash) April 12, 2022 13:37
@RyanTheOptimist
Copy link
Copy Markdown
Contributor Author

RyanTheOptimist commented Apr 12, 2022

/assign @alyssawilk

@RyanTheOptimist RyanTheOptimist merged commit 7845ef4 into envoyproxy:main Apr 12, 2022
vehre-x41 pushed a commit to vehre-x41/envoy that referenced this pull request Apr 19, 2022
@RyanTheOptimist @vehre-x41
Update QUICHE from bac04054b to 8864d08f6 (envoyproxy#20747)
97fd499 
Update QUICHE from bac04054b to 8864d08f6
https://github.com/google/quiche/compare/bac04054b..8864d08f6

$ git log bac04054b..8864d08f6 --date=short --no-merges --format="%ad %al %s"

2022-04-11 diannahu Fix the receipt of GOAWAYs as the server in oghttp2.
2022-04-11 danzh Automated g4 rollback of changelist 437128224.
2022-04-11 bnc Platformize enforcing header policy in Balsa.
2022-04-11 vasilvv Use relative include paths for OpenSSL and zlib in QUICHE.
2022-04-11 diannahu Handle new/pending streams on receipt of a GOAWAY in oghttp2.
2022-04-11 bnc Fix header guards in QUICHE.
2022-04-11 wub Deprecate --gfe2_reloadable_flag_quic_tls_no_select_cert_if_disconnected.
2022-04-11 fayang Internal change
2022-04-08 rch Make QUICHE pragmas which disable warnings google3-specific.
2022-04-08 haoyuewang Remove connection_option RVCM such that IETF QUIC connection migration is default on.
2022-04-08 wub Change QuicPathChallengeFrame and QuicPathResponseFrame to be inlined quic frame.
2022-04-07 diannahu Update oghttp2 to close streams above a received GOAWAY's last_stream_id.
2022-04-07 renjietang Change default path degrading delay to 4PTOs when PTO is enabled.
2022-04-07 martinduke Minor cleanup of the QUIC-LB library. Take review comments from late in the process and apply them to earlier classes.
2022-04-07 quiche-dev Internal change

Signed-off-by: Ryan Hamilton rch@google.com
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
@RyanTheOptimist @ravenblackx
Update QUICHE from bac04054b to 8864d08f6 (envoyproxy#20747)
87ac0fb 
Update QUICHE from bac04054b to 8864d08f6
https://github.com/google/quiche/compare/bac04054b..8864d08f6

$ git log bac04054b..8864d08f6 --date=short --no-merges --format="%ad %al %s"

2022-04-11 diannahu Fix the receipt of GOAWAYs as the server in oghttp2.
2022-04-11 danzh Automated g4 rollback of changelist 437128224.
2022-04-11 bnc Platformize enforcing header policy in Balsa.
2022-04-11 vasilvv Use relative include paths for OpenSSL and zlib in QUICHE.
2022-04-11 diannahu Handle new/pending streams on receipt of a GOAWAY in oghttp2.
2022-04-11 bnc Fix header guards in QUICHE.
2022-04-11 wub Deprecate --gfe2_reloadable_flag_quic_tls_no_select_cert_if_disconnected.
2022-04-11 fayang Internal change
2022-04-08 rch Make QUICHE pragmas which disable warnings google3-specific.
2022-04-08 haoyuewang Remove connection_option RVCM such that IETF QUIC connection migration is default on.
2022-04-08 wub Change QuicPathChallengeFrame and QuicPathResponseFrame to be inlined quic frame.
2022-04-07 diannahu Update oghttp2 to close streams above a received GOAWAY's last_stream_id.
2022-04-07 renjietang Change default path degrading delay to 4PTOs when PTO is enabled.
2022-04-07 martinduke Minor cleanup of the QUIC-LB library. Take review comments from late in the process and apply them to earlier classes.
2022-04-07 quiche-dev Internal change

Signed-off-by: Ryan Hamilton rch@google.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

@danzh2010 danzh2010 danzh2010 left review comments

Assignees

@mattklein123 mattklein123

@alyssawilk alyssawilk

@danzh2010 danzh2010

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RyanTheOptimist @danzh2010 @diannahu @moderation @mattklein123 @alyssawilk