Skip to content

delta-xds: fix wildcard resource versions#20726

Merged
htuch merged 2 commits intoenvoyproxy:mainfrom
adisuissa:delta_xds_fix_map
Apr 10, 2022
Merged

delta-xds: fix wildcard resource versions#20726
htuch merged 2 commits intoenvoyproxy:mainfrom
adisuissa:delta_xds_fix_map

Conversation

@adisuissa
Copy link
Copy Markdown
Contributor

Commit Message: delta-xds fix wildcard resource versions
Additional Description: Fixing a bug in delta-xDS where the versions of the wildcard resources are not updated, and may result in wasted passing of resources, and usage of stale resources.
Risk Level: Low
Testing: Added a unit test.
Docs Changes: N/A
Release Notes:
Platform Specific Features: N/A
Fixes #Issue: #20699

Signed-off-by: Adi Suissa-Peleg adip@google.com

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa adisuissa assigned adisuissa and htuch and unassigned adisuissa Apr 8, 2022
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 8bd59ce into envoyproxy:main Apr 10, 2022
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
Fixing a bug in delta-xDS where the versions of the wildcard resources are not updated, and may result in wasted passing of resources, and usage of stale resources.

Risk Level: Low
Testing: Added a unit test.
Docs Changes: N/A
Release Notes:
Platform Specific Features: N/A
Fixes #Issue: envoyproxy#20699

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants