contrib-sipproxy: Fix the issue when teardown#20580
Merged
wbpcode merged 1 commit intoenvoyproxy:mainfrom Apr 12, 2022
Merged
Conversation
When their are more than one TRA subscribe actions, stream_ maybe overwrited which cause the last connection can't be resetted gracefully. so introduce a list of stream_callbacks and request_callbacks. Signed-off-by: Felix Du <durd07@gmail.com>
Member
Author
|
@envoyproxy/envoy-maintainers PTAK. |
Member
|
/assign |
Member
Author
Member
Author
|
@envoyproxy/admins @envoyproxy/envoy-maintainers Could anyone help to review and merge this contrib PR? |
Member
|
Sorry for the late reply. I was on my vacation last week. |
wbpcode
approved these changes
Apr 11, 2022
Member
wbpcode
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contributions. And cc @envoyproxy/senior-maintainers for merge or second pass.
lizan
approved these changes
Apr 12, 2022
vehre-x41
pushed a commit
to vehre-x41/envoy
that referenced
this pull request
Apr 19, 2022
When their are more than one TRA subscribe actions, stream_ maybe overwrited which cause the last connection can't be resetted gracefully. so introduce a list of stream_callbacks and request_callbacks. Signed-off-by: Felix Du <durd07@gmail.com> Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
When their are more than one TRA subscribe actions, stream_ maybe overwrited which cause the last connection can't be resetted gracefully. so introduce a list of stream_callbacks and request_callbacks. Signed-off-by: Felix Du <durd07@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When their are more than one TRA subscribe actions, stream_ maybe
overwrited which cause the last connection can't be resetted gracefully.
so introduce a list of stream_callbacks and request_callbacks.
Signed-off-by: Felix Du durd07@gmail.com
Commit Message: contrib-sipproxy: Fix the coredump when teardown
Additional Description: When their are more than one TRA subscribe actions, stream_ maybe overwrited which cause the last connection can't be resetted gracefully. so introduce a list of stream_callbacks and request_callbacks to fix it.
Risk Level: Low
Testing: unit test/integrated test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]