xds: don't allow multiple instances of a locality in the same priority#20574
xds: don't allow multiple instances of a locality in the same priority#20574adisuissa merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Mark D. Roth <roth@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
@adisuissa this has been waiting for 9 days. If your concern is CI, please comment as such and tag it as waiting. |
|
/retest If this does not resolve, @markdroth please merge main (even an empty commit should trigger a new build which will cause a CI run against the current main.) |
|
Retrying Azure Pipelines: |
…ities Signed-off-by: Mark D. Roth <roth@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
@markdroth is there an issue tracking the convergence to the restrictive behavior? |
|
No, there isn't, but feel free to create one. The main thing I'm after here is defining the API semantics such that the same locality does not repeat in the same priority. If Envoy's implementation is a bit more permissive than the API spec, that's not the end of the world. I just don't want new people implementing their xDS servers in a way that doesn't work for gRPC clients. |
Opened #20768 to track this. |
adisuissa
left a comment
There was a problem hiding this comment.
/lgtm api
Should be merged once CI is green.
envoyproxy#20574) Signed-off-by: Mark D. Roth <roth@google.com> Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
envoyproxy#20574) Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth roth@google.com
Commit Message: xds: don't allow multiple instances of a locality in the same priority
Additional Description: This is a documentation-only change. gRPC is a bit more restrictive here than Envoy is. This changes the documented requirement to match gRPC's restriction but does not change Envoy's implementation, with the goal being to converge on the more restrictive behavior in the long term but not break anything in the short term.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A