Skip to content

redis: implement drain close functionality#2037

Merged
mattklein123 merged 2 commits intomasterfrom
redis_drain
Nov 9, 2017
Merged

redis: implement drain close functionality#2037
mattklein123 merged 2 commits intomasterfrom
redis_drain

Conversation

@mattklein123
Copy link
Copy Markdown
Member

Risk Level: Low

Testing: UT only

Signed-off-by: Matt Klein <mklein@lyft.com>
callbacks_->connection().write(encoder_buffer_);
}

// fixfix
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops will fix

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Copy Markdown
Member Author

@danielhochman fixed

@mattklein123 mattklein123 merged commit b627a64 into master Nov 9, 2017
@mattklein123 mattklein123 deleted the redis_drain branch November 9, 2017 23:53
Shikugawa pushed a commit to Shikugawa/envoy that referenced this pull request Mar 28, 2020
* Update Envoy SHA to fcc68f1

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>

* Update SHA256

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Shikugawa pushed a commit to Shikugawa/envoy that referenced this pull request Mar 28, 2020
* Improve performance by removing MD5 for check cache keys (envoyproxy#2002)

* Improve performance by removing MD5 for check cache keys

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* not to allocate memory from stack

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* Make debug string readable

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* alts: remove ALTS (envoyproxy#2003)

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* Use std::hash for check cache. (envoyproxy#2009)

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* Remove tests to compare signature values (envoyproxy#2015)

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* update sample envoy config to latest version (envoyproxy#2016)

* Add a new TCP cluster rewrite filter (envoyproxy#2017)

* Add a new TCP cluster rewrite filter

This commit adds a new TCP cluster rewrite filter which allows users to
rewrite TCP cluster names obtained via TLS SNI by matching via regex
configuration.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Make TCP cluster rewrite stackable on SNI filter

This commit updates the TCP Cluster Rewrite filter to be stackable on
the SNI Cluster filter.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Update TCP Cluster Rewrite filter name (envoyproxy#2019)

This commit updates the TCP Cluster Rewrite filter name to
envoy.filters.network.tcp_cluster_rewrite.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Enable TCP Cluster Rewrite filter registration (envoyproxy#2021)

This commit enables the static registration of the TCP Cluster Rewrite
filter by updating the build configuration.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Update Envoy SHA to 4ef8562 (envoyproxy#2023)

Envoy /server_info API was inconsistent intermittently causing errors on
a Proxy update on Istio. This update will bring in the API fix to Istio.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* add proxy postsubmit periodic (envoyproxy#2025)

* Update Envoy SHA to c41fa71 (envoyproxy#2029)

* Update Envoy SHA

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>

* Fix format.

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>

* bazel: Allow to distdir all dependencies (envoyproxy#2034)

To use --distdir option of Bazel (which allows to use previously
fetched tarballs instead of downloading dependencies during
build), all dependencies should use http instead of git and need
to have sha256 sums specified.

Signed-off-by: Michal Rostecki <mrostecki@suse.de>

* bazel: Remove BoringSSL repository (envoyproxy#2035)

Pull request envoyproxy#2002 removed signature calculation which was using
BoringSSL as a dependency. BoringSSL is not needed anymore.

Signed-off-by: Michal Rostecki <mrostecki@suse.de>

* Update Envoy SHA to fcc68f1 (envoyproxy#2037)

* Update Envoy SHA to fcc68f1

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>

* Update SHA256

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
jpsim added a commit that referenced this pull request Nov 28, 2022
…#2037)

Following the instructions in https://github.com/bazelbuild/bazel-toolchains

Specifically:

    $ ./rbe_configs_gen \
            --bazel_version="4.2.1" \
            --toolchain_container="docker.io/envoyproxy/envoy-build-ubuntu:514e2f7bc36c1f0495a523b16aab9168a4aa13b6" \
            --exec_os="linux" \
            --target_os="linux" \
            --output_src_root="/path/to/envoy-mobile" \
            --output_config_path="third_party/rbe_configs" \
            --cpp_env_json=clang.json \
            --generate_java_configs=False
    $ cat clang.json
    {"CC": "/opt/llvm/bin/clang", "CXX": "/opt/llvm/bin/clang++"}

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit that referenced this pull request Nov 29, 2022
…#2037)

Following the instructions in https://github.com/bazelbuild/bazel-toolchains

Specifically:

    $ ./rbe_configs_gen \
            --bazel_version="4.2.1" \
            --toolchain_container="docker.io/envoyproxy/envoy-build-ubuntu:514e2f7bc36c1f0495a523b16aab9168a4aa13b6" \
            --exec_os="linux" \
            --target_os="linux" \
            --output_src_root="/path/to/envoy-mobile" \
            --output_config_path="third_party/rbe_configs" \
            --cpp_env_json=clang.json \
            --generate_java_configs=False
    $ cat clang.json
    {"CC": "/opt/llvm/bin/clang", "CXX": "/opt/llvm/bin/clang++"}

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants