quic: upstream sends early data requests#20167
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
|
looks like CI bounced. is this ready for another pass? |
Signed-off-by: Dan Zhang <danzh@google.com>
Yes, I addressed all the comments. But I haven't checked the test coverage due to the CI failure. |
source/common/config/utility.h
Outdated
| static Factory* getAndCheckFactory(const ProtoMessage& message, bool is_optional) { | ||
| Factory* factory = Utility::getFactoryByType<Factory>(message.typed_config()); | ||
| if (Runtime::runtimeFeatureEnabled("envoy.reloadable_features.no_extension_lookup_by_name")) { | ||
| std::cerr |
There was a problem hiding this comment.
remove cerr here and below
alyssawilk
left a comment
There was a problem hiding this comment.
hm, I think you still had some debug code here?
/wait
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM modulo coverage checks (which are re-running)
Passing to ggreenway for !google pass and another close look at the conn pool changes
alyssawilk
left a comment
There was a problem hiding this comment.
Yeah, looks like a drop in coverage from
main: https://storage.googleapis.com/envoy-postsubmit/main/coverage/index.html
to this: https://storage.googleapis.com/envoy-pr/cca81ac/coverage/index.html
alyssawilk
left a comment
There was a problem hiding this comment.
on second look at coverage it looks like new lines are covered - I'm baffled by the coverage line count being lower but that's not your problem
LGTM but please main mereg
Signed-off-by: Dan Zhang <danzh@google.com>
|
ping @ggreenway |
ggreenway
left a comment
There was a problem hiding this comment.
LGTM.
I'd say this is probably high risk; the connection pool code and it's interactions are complicated. But everything looks good; I don't see any issues.
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Dan Zhang <danzh@google.com>
|
@markdroth I think we need another API stamp? |
Commit Message: make HTTP/3 upstream sends 0-RTT (early data) requests if it has cached 0-RTT credentials. Add a config knob in RouteAction to specify which request can be sent over early data, which by default are HTTP safe methods. Risk Level: high, changes to conn pool behavior though should only take effect for h3 pool Testing: added h3 upstream integration tests. Docs Changes: N/A Release Notes: changes to docs/root/version_history/current.rst Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.http3_sends_early_data Fixes envoyproxy#18715, envoyproxy#19542 Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Dan Zhang <danzh@google.com>
Commit Message: make HTTP/3 upstream sends 0-RTT (early data) requests if it has cached 0-RTT credentials. Add a config knob in RouteAction to specify which request can be sent over early data, which by default are HTTP safe methods.
Risk Level: high, changes to conn pool behavior though should only take effect for h3 pool
Testing: added h3 upstream integration tests.
Docs Changes: N/A
Release Notes: changes to docs/root/version_history/current.rst
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.http3_sends_early_data
Fixes #18715, #19542