stats: remove symbol table interface file and rename files to be consistent#19788
Merged
jmarantz merged 9 commits intoenvoyproxy:mainfrom Feb 4, 2022
Merged
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…a dependency. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
Hi @zuercher this is the follow-up to the PR you reviewed earlier, cleaning up filenames and removing the extinct interface file. It's large but really mostly simple renames. |
Contributor
Author
|
Thanks Stephan! |
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Feb 8, 2022
- Update `ENVOY_COMMIT` to the latest Envoy's commit envoyproxy/envoy#19843. - Replace `envoy/source/common/stats/symbol_table_impl.h` by `envoy/source/common/stats/symbol_table.h` and remove `envoy/stats/symbol_table.h`. See envoyproxy/envoy#19788 for more details. - Sync the `.bazelrc` to the current Envoy's version. - Sync the `bazel` version to the current Envoy's version. Signed-off-by: jiajunye <jiajunye@google.com>
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
…istent (envoyproxy#19788) Commit Message: follow-up to envoyproxy#19597 -- removes trivial forward decls from envoy/stats/symbol_table.h and renames all the files to reflect this is no longer an interface/impl pattern but a single implementation. This PR has a lot of files but all the changes are renames of includes except for the removal of envoy/stats/symbol_table.h and the moving of its forward decls into envoy/stats/stats.h. Additional Description: Risk Level: llw Testing: //test/... Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: follow-up to #19597 -- removes trivial forward decls from envoy/stats/symbol_table.h and renames all the files to reflect this is no longer an interface/impl pattern but a single implementation.
This PR has a lot of files but all the changes are renames of includes except for the removal of envoy/stats/symbol_table.h and the moving of its forward decls into envoy/stats/stats.h.
Additional Description:
Risk Level: llw
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a