deps: integrate and use local copy of http-parser library#19786
deps: integrate and use local copy of http-parser library#19786phlax merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
For context, we are supporting the unified header validation component and have been coordinating our work with @yanavlasov |
|
just from pov of cve noise from nodejs this would be good @ameily you need to do some format fixing - diff is available in the artefacts here https://dev.azure.com/cncf/envoy/_build/results?buildId=100606&view=results cc @htuch for approval on including this in Envoy code base |
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Sorry about that, I apparently didn't have my virtualenv setup properly so the test wasn't running locally. It should be fixed now. |
|
I'm on the fence on this one. I think we decided not to fork http-parser and we're pursuing a strategy of moving to a QUICHE-based parser. @yanavlasov do you have an ETA for when we will have a replacement parser? I'd feel more comfortable if we could say "this is just for 4 months and then we will switch to default QUICHE. |
|
@htuch balsa integration into Envoy will not start until H2. We will need to make some changes to http-parser in the interim to move forward with the unified header validation. Hence this fork. This is temporary until http-parser can be ditched for balsa. |
|
Ack, no objection then. |
|
@ameily looks like you have some remaining issues with clang-tidy: |
|
@phlax This is third-party code so I added it to the exclusion list in |
yep, agreed |
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
…#19786) * integrate and use local copy of http-parser; refs envoyproxy#19749 * ignore third party dependency: http-parser * exclude http-parser third-party code from clang-tidy Signed-off-by: Adam Meily <adam.meily@trailofbits.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
Commit Message: deps: integrate and use local copy of http-parser library
Additional Description: As part of the unified header validation component, Envoy will need to eventually modify the http-parser behavior based on the active configuration (see #19750 and #19757). This PR covers the first step of that goal by bringing http-parser into the Envoy repository and get it building with Bazel. This PR contains the http-parser code, without any modifications, from the commit nodejs/http-parser@4f15b7d.
Risk Level: Low
Testing: Build Envoy and run the HTTP protocol integration tests.
Docs Changes: None
Release Notes: None
Platform Specific Features: None
Fixes #19749