decompressor: add config flag to ignore no-transform#19399
Merged
rojkov merged 9 commits intoenvoyproxy:mainfrom Jan 7, 2022
jpsim:lenient-no-transform
Merged
decompressor: add config flag to ignore no-transform#19399rojkov merged 9 commits intoenvoyproxy:mainfrom jpsim:lenient-no-transform
rojkov merged 9 commits intoenvoyproxy:mainfrom
jpsim:lenient-no-transform
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
This allows matching the more lenient behavior of other client-side networking libraries such as OkHttp or URLSession, especially in cases where the remote server is not under the client developer's control. Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
snowp
suggested changes
Jan 5, 2022
Contributor
snowp
left a comment
There was a problem hiding this comment.
Couple nits, otherwise this lgtm!
api/envoy/extensions/filters/http/decompressor/v3/decompressor.proto
Outdated
Show resolved
Hide resolved
source/extensions/filters/http/decompressor/decompressor_filter.h
Outdated
Show resolved
Hide resolved
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
|
Also this needs @envoyproxy/api-shepherds approval |
htuch
reviewed
Jan 6, 2022
api/envoy/extensions/filters/http/decompressor/v3/decompressor.proto
Outdated
Show resolved
Hide resolved
api/envoy/extensions/filters/http/decompressor/v3/decompressor.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
Author
Contributor
Author
|
Thanks for the feedback everyone. |
buildbreaker
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jan 7, 2022
Commit Message: Decompress even when `no-transform` is specified Additional Description: This leverages the flag added in envoyproxy/envoy#19399 to always decompress responses, regardless of the presence of a `no-transform` cache control header, matching the more lenient behavior of other client-side networking libraries such as OkHttp or URLSession, especially in cases where the remote server is not under the client developer's control. Risk Level: Low, responses that would previously fail to decode will now succeed when a compressed response comes with a `no-transform` cache control header. Testing: Added unit tests in Envoy and manually confirmed in an Android app that gzipped responses with `no-transform` that previously failed now succeed. Docs Changes: Not needed. Release Notes: Added. Platform Specific Features: This is configured to apply regardless of the platform, so both iOS & Android will get this new behavior.
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
This allows matching the more lenient behavior of other client-side networking libraries such as OkHttp or URLSession, especially in cases where the remote server is not under the client developer's control. Risk Level: Low, defaults are unaffected, change is opt-in. Testing: Added unit tests for existing no-transform behavior (there was none) and a new test validating the new configuration flag. Docs Changes: Updated. Release Notes: Added. Signed-off-by: JP Simard <jp@jpsim.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
Commit Message: Decompress even when `no-transform` is specified Additional Description: This leverages the flag added in #19399 to always decompress responses, regardless of the presence of a `no-transform` cache control header, matching the more lenient behavior of other client-side networking libraries such as OkHttp or URLSession, especially in cases where the remote server is not under the client developer's control. Risk Level: Low, responses that would previously fail to decode will now succeed when a compressed response comes with a `no-transform` cache control header. Testing: Added unit tests in Envoy and manually confirmed in an Android app that gzipped responses with `no-transform` that previously failed now succeed. Docs Changes: Not needed. Release Notes: Added. Platform Specific Features: This is configured to apply regardless of the platform, so both iOS & Android will get this new behavior. Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add config flag to decompress even when no-transform is specified
Additional Description: This allows matching the more lenient behavior of other client-side networking libraries such as OkHttp or URLSession, especially in cases where the remote server is not under the client developer's control.
Risk Level: Low, defaults are unaffected, change is opt-in.
Testing: Added unit tests for existing
no-transformbehavior (there was none) and a new test validating the new configuration flag.Docs Changes: Updated.
Release Notes: Added.
Platform Specific Features: