docs: fix links for public docs#19018
Conversation
Previously doc paths were not updated within envoyproxy#8027. Resolves envoyproxy#19017. Signed-off-by: Kristopher Wuollett <kristopher.wuollett@gmail.com>
|
Hi @kriswuollett, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
Does the |
possibly, i will need to review the pr further to figure out we can use redirects to either fix a broken historical link eg posted elsewhere, or when we are actually moving a page that has existed the PR seems to have triggered an upstream flake /retest |
|
Retrying Azure Pipelines: |
|
docs (will be) rendered here https://storage.googleapis.com/envoy-pr/19018/docs/index.html |
|
The only potential explanation for the error I see in the presubmit run is:
Is that what could be the source of the flake? |
yep, it is |
|
/retest |
|
Retrying Azure Pipelines: |
|
@kriswuollett looks like this PR needs a main merge it would be good to fix these links |
|
@phlax, sure thing. Will update them now. |
The www prefix is not used as it would be removed by a HTTP redirect. Signed-off-by: Kristopher Wuollett <kristopher.wuollett@gmail.com>
64c586e to
42fa4df
Compare
|
I can also update all the other links like in the Markdown files to not have the redirect from the |
phlax
left a comment
There was a problem hiding this comment.
thanks for updating @kriswuollett
there are a few repo links left and then this should be good to land
source/extensions/filters/http/grpc_http1_bridge/http1_bridge_filter.h
Outdated
Show resolved
Hide resolved
lets address that in a separate PR |
82f495e to
db3fd9f
Compare
Signed-off-by: Kristopher Wuollett <kristopher.wuollett@gmail.com>
db3fd9f to
a93cd7e
Compare
|
@kriswuollett i think the formatting issues are because you need to merge main |
|
/wait |
phlax
left a comment
There was a problem hiding this comment.
@kriswuollett thanks for taking the time to go through and fix these, lgtm
Previously doc paths were not updated within envoyproxy#8027. Resolves envoyproxy#19017. * doc: Update doc paths to use full public URLs The www prefix is not used as it would be removed by a HTTP redirect. Signed-off-by: Kristopher Wuollett <kristopher.wuollett@gmail.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
Previously doc paths were not updated within #8027. Resolves #19017.
Signed-off-by: Kristopher Wuollett kristopher.wuollett@gmail.com
Commit Message: docs: fix links for public docs
Additional Description: fixes links from file migration in #8027
Risk Level: Low
Testing: N/A
Docs Changes: Yes
Release Notes: N/A
Platform Specific Features: N/A