udp_proxy: added per packet load balancing possibility by michalmaka · Pull Request #18605 · envoyproxy/envoy

michalmaka · 2021-10-13T12:56:01Z

Signed-off-by: Michał Mąka m.maka@partner.samsung.com

Commit Message: udp_proxy: added per packet load balancing possibility which can be enabled via specifying 'use_per_packet_load_balancing' field
Additional Description:
This feature adds possibility to have per packet load balancing in UDP proxy. Currently, there is kind of sticky session, which means that once data was forwarded to specific upstream host, the host is also used for subsequent messages if timeout does not occur.
By default, current behavior is used, but if use_per_packet_load_balancing configuration flag is set to true, on each data receival, new upstream host is selected and receives that data.
Risk Level: Medium
Testing: unit test, manual testing
Docs Changes: Introduced description of the feature and a way it can be enabled
Release Notes: Added to current.rst
Platform Specific Features: N/A

repokitteh-read-only · 2021-10-13T12:56:05Z

Hi @michalmaka, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #18605 was opened by michalmaka.

see: more, trace.

repokitteh-read-only · 2021-10-13T12:56:10Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #18605 was opened by michalmaka.

see: more, trace.

mattklein123

Thanks in general this makes sense to me. Some high level comments to get started. Thank you!

/wait

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc

mattklein123

Looks like it's heading on the right track, thanks. Please merge main and address the template issue and then I can look again.

/wait

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

…unhealthy host Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

repokitteh-read-only · 2021-11-12T09:43:04Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #18605 was synchronize by michalmaka.

see: more, trace.

…s base class was factored out Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

mattklein123

Thanks looking good. A couple of other high level questions.

/wait

docs/root/configuration/listeners/udp_filters/udp_proxy.rst

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.h

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

mattklein123

Thanks generally LGTM. Just a few small comments and please revert any change that isn't needed anymore due to the simpler implementation.

/wait

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.h

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.h

mattklein123

Thanks LGTM with one remaining small nit/question.

/wait-any

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.h

mattklein123 · 2021-11-18T22:06:18Z

Can you fix DCO?

/wait

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

michalmaka · 2021-11-19T10:03:21Z

Can you fix DCO?

/wait

Done

mattklein123 · 2021-11-19T16:21:02Z

/retest

repokitteh-read-only · 2021-11-19T16:21:07Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18605 (comment) was created by @mattklein123.

see: more, trace.

mattklein123

Thanks, nice work!

michalmaka · 2021-11-22T06:43:09Z

thanks!

michalmaka requested a review from mattklein123 as a code owner October 13, 2021 12:56

repokitteh-read-only bot added the api label Oct 13, 2021

repokitteh-read-only bot assigned markdroth Oct 13, 2021

mattklein123 assigned mattklein123 and unassigned markdroth Oct 13, 2021

mattklein123 requested changes Oct 13, 2021

View reviewed changes

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc Outdated Show resolved Hide resolved

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added waiting and removed waiting labels Oct 13, 2021

mattklein123 added the waiting label Oct 14, 2021

repokitteh-read-only bot removed the waiting label Oct 21, 2021

mattklein123 requested changes Oct 21, 2021

View reviewed changes

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Oct 21, 2021

Michal Maka added 2 commits November 12, 2021 10:23

Added functionality for per packet load balancing in udp_proxy

bdc613f

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

Code deduplication, getting rid of checking if load balancer returns …

0f2efb2

…unhealthy host Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

michalmaka force-pushed the per_packet_udp_load_balancing branch from c58a593 to 0f2efb2 Compare November 12, 2021 09:42

repokitteh-read-only bot removed the waiting label Nov 12, 2021

Michal Maka added 2 commits November 12, 2021 10:49

Removed template classes for per packet loadbalancing. Instead of thi…

2344634

…s base class was factored out Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

Fixed clang-tidy issues

c625d5d

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

mattklein123 reviewed Nov 12, 2021

View reviewed changes

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Nov 12, 2021

Extracted host selection and possibility of connection creation

0e03e96

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

repokitteh-read-only bot removed the waiting label Nov 15, 2021

mattklein123 reviewed Nov 15, 2021

View reviewed changes

docs/root/configuration/listeners/udp_filters/udp_proxy.rst Outdated Show resolved Hide resolved

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.h Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Nov 15, 2021

Fixed documentation error

b3959e2

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

repokitteh-read-only bot removed the waiting label Nov 16, 2021

mattklein123 added the waiting label Nov 16, 2021

Added flag for taking host into consideration for heterogenous lookup

32a3e8c

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

repokitteh-read-only bot removed the waiting label Nov 17, 2021

mattklein123 requested changes Nov 17, 2021

View reviewed changes

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.h Outdated Show resolved Hide resolved

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc Outdated Show resolved Hide resolved

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.h Show resolved Hide resolved

repokitteh-read-only bot added waiting and removed waiting labels Nov 17, 2021

mattklein123 reviewed Nov 18, 2021

View reviewed changes

source/extensions/filters/udp/udp_proxy/udp_proxy_filter.h Outdated Show resolved Hide resolved

repokitteh-read-only bot added waiting:any and removed waiting:any labels Nov 18, 2021

repokitteh-read-only bot added the waiting label Nov 18, 2021

michalmaka force-pushed the per_packet_udp_load_balancing branch from 170fde8 to 2047fcf Compare November 18, 2021 22:09

repokitteh-read-only bot removed the waiting label Nov 18, 2021

Michal Maka added 3 commits November 18, 2021 23:20

Apply suggestions from code review

73a8996

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

Removed no more used functions after code simplification

cedba1e

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

Removed typedef for optional HostSharedPtr

a0fd8b1

Signed-off-by: Michal Maka <m.maka@partner.samsung.com>

michalmaka force-pushed the per_packet_udp_load_balancing branch from 2047fcf to a0fd8b1 Compare November 18, 2021 22:28

mattklein123 approved these changes Nov 19, 2021

View reviewed changes

repokitteh-read-only bot removed the api label Nov 19, 2021

mattklein123 merged commit 23e5fc2 into envoyproxy:main Nov 19, 2021

michalmaka deleted the per_packet_udp_load_balancing branch November 22, 2021 06:43

Conversation

michalmaka commented Oct 13, 2021

Uh oh!

repokitteh-read-only bot commented Oct 13, 2021

Uh oh!

repokitteh-read-only bot commented Oct 13, 2021

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

repokitteh-read-only bot commented Nov 12, 2021

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattklein123 commented Nov 18, 2021

Uh oh!

michalmaka commented Nov 19, 2021

Uh oh!

mattklein123 commented Nov 19, 2021

Uh oh!

repokitteh-read-only bot commented Nov 19, 2021

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

michalmaka commented Nov 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants