docs: update theme to fix sidebar issue#1860
Merged
mattklein123 merged 1 commit intomasterfrom Oct 16, 2017
Merged
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
danielhochman
approved these changes
Oct 16, 2017
htuch
approved these changes
Oct 16, 2017
rshriram
added a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…roxy#1860) This reverts commit f47be07.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
…out inprogress (#1860) **Description** There have been sequences when the routes have been deleted and created. The extProc sidecar would not be injected. We noticed this due to a condition when the rollout is in progress, and a few pods are in a terminating state but have an extProc sidecar in them. It does not inject the sidecar in some cases (e.g., with multiple replicas). To fix this issue, we add a check to look for deployment/daemonset status if they are in progress. Requeue with a 5-second timeout. Additionally, check whether the sidecar is present in each pod. This is to ensure that, in multi-replica cases, there are no scenarios with inconsistent state (some with sidecar and some without). If there is an inconsistent state, we force rollout. Changes: - Skip terminating pods from checks and Consolidated checking of pods with sidecar into `checkPodHasSideCar()` - Included `isRolloutInProgress()` for checking inprogress **Related Issues/PRs (if applicable)** Fixes: #1857 **Special notes for reviewers (if applicable)** Tested this change by running a sequence of creation -> deletion of routes. After the sequence was complete. The replicas were inconsistent state which triggered a force rollout ``` INFO controller.gateway pods are inconsistent while rollout is stable, forcing rollout {"podsWithSidecarSeen": true, "podsWithoutSidecarSeen": true} ``` Requesting thoughts/feedback on this approach --------- Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Klein mklein@lyft.com