Skip to content

docs: update theme to fix sidebar issue#1860

Merged
mattklein123 merged 1 commit intomasterfrom
fix_docs
Oct 16, 2017
Merged

docs: update theme to fix sidebar issue#1860
mattklein123 merged 1 commit intomasterfrom
fix_docs

Conversation

@mattklein123
Copy link
Copy Markdown
Member

Signed-off-by: Matt Klein mklein@lyft.com

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123 mattklein123 merged commit 38b81c4 into master Oct 16, 2017
@mattklein123 mattklein123 deleted the fix_docs branch October 16, 2017 03:26
rshriram added a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake pushed a commit that referenced this pull request Mar 3, 2026
…out inprogress (#1860)

**Description**
There have been sequences when the routes have been deleted and created.
The extProc sidecar would not be injected. We noticed this due to a
condition when the rollout is in progress, and a few pods are in a
terminating state but have an extProc sidecar in them. It does not
inject the sidecar in some cases (e.g., with multiple replicas).

To fix this issue, we add a check to look for deployment/daemonset
status if they are in progress. Requeue with a 5-second timeout.
Additionally, check whether the sidecar is present in each pod. This is
to ensure that, in multi-replica cases, there are no scenarios with
inconsistent state (some with sidecar and some without). If there is an
inconsistent state, we force rollout.

Changes:
- Skip terminating pods from checks and Consolidated checking of pods
with sidecar into `checkPodHasSideCar()`
- Included `isRolloutInProgress()` for checking inprogress


**Related Issues/PRs (if applicable)**
Fixes: #1857 

**Special notes for reviewers (if applicable)**

Tested this change by running a sequence of creation -> deletion of
routes. After the sequence was complete. The replicas were inconsistent
state which triggered a force rollout

```
INFO	controller.gateway	pods are inconsistent while rollout is stable, forcing rollout	{"podsWithSidecarSeen": true, "podsWithoutSidecarSeen": true}
```

Requesting thoughts/feedback on this approach

---------

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants