Skip to content

Clean up for xDS v2 deprecation#17924

Merged
mattklein123 merged 14 commits intoenvoyproxy:mainfrom
tyxia:deprecate
Oct 19, 2021
Merged

Clean up for xDS v2 deprecation#17924
mattklein123 merged 14 commits intoenvoyproxy:mainfrom
tyxia:deprecate

Conversation

@tyxia
Copy link
Copy Markdown
Member

@tyxia tyxia commented Aug 31, 2021

Removed hidden_envoy_deprecated_ related util code and test code

Signed-off-by: Tianyu Xia tyxia@google.com

Risk Level: Low
Testing: CI, local test

Signed-off-by: Tianyu Xia <tyxia@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #17924 was opened by tyxia.

see: more, trace.

tyxia added 4 commits August 31, 2021 12:50
Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
…cate

Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
…cate

Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #17924 was synchronize by tyxia.

see: more, trace.

@tyxia
Copy link
Copy Markdown
Member Author

tyxia commented Sep 21, 2021

/unassign @markdroth

tyxia added 2 commits October 18, 2021 12:24
…cate

Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
@tyxia tyxia marked this pull request as ready for review October 18, 2021 14:41
@tyxia tyxia requested a review from htuch October 18, 2021 14:41
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mattklein123 mattklein123 merged commit 566282b into envoyproxy:main Oct 19, 2021
@tyxia tyxia deleted the deprecate branch March 15, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants