test: convert //test/integration:ratelimit_integration_test to proto.#1790
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Oct 2, 2017
Merged
test: convert //test/integration:ratelimit_integration_test to proto.#1790htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
mattklein123
reviewed
Oct 2, 2017
| createTestServer("test/config/integration/server_grpc_json_transcoder.json", {"http"}); | ||
| } | ||
|
|
||
| TEST_P(LegacyJsonIntegrationTest, TestServerRatelimit) { |
Member
There was a problem hiding this comment.
Any particular reason to remove from the legacy integration config tests?
Member
Author
There was a problem hiding this comment.
Just mopping up the JSON, we can keep it there if you prefer. I think we have sufficient coverage from the proto-based test.
Member
There was a problem hiding this comment.
It's not a big deal. I still feel like we are losing some ease of inspection of what is actually being tested without being able to scan the full configs, but I will get over it.
mattklein123
approved these changes
Oct 2, 2017
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
…envoyproxy#1790) Signed-off-by: Harvey Tuch <htuch@google.com>
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Not to flush out batched report in destructor * Add the mutex back * Change wording
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…" (envoyproxy#1793) This reverts commit e9cdb20.
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This removed redundant config watcher start call. Signed-off-by: fengxsong <fengxsong@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harvey Tuch htuch@google.com