config: few changes to help with protobuf string type mismatch.#1786
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Sep 30, 2017
Merged
config: few changes to help with protobuf string type mismatch.#1786mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
This is helpful for Google import and shouldn't affect anybody else. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
| const std::string& Filter::upstreamZone(Upstream::HostDescriptionConstSharedPtr upstream_host) { | ||
| return upstream_host ? upstream_host->locality().zone() : EMPTY_STRING; | ||
| const std::string Filter::upstreamZone(Upstream::HostDescriptionConstSharedPtr upstream_host) { | ||
| return upstream_host ? upstream_host->locality().zone() : ""; |
Member
There was a problem hiding this comment.
Please add a TODO here also.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
mattklein123
approved these changes
Sep 30, 2017
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
…yproxy#1786) This is helpful for Google import and shouldn't affect anybody else. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: On mobile, backgrounding might cause the host to be past its TTL without good reason. Given the host would be deleted, and new streams for a given domain would have to wait for resolution, it is better to not delete existing hosts; especially since deletion only happens when re-resolving is already in progress. There is no way to disable so the value below is equivalent to 24 hours. Risk Level: low Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: On mobile, backgrounding might cause the host to be past its TTL without good reason. Given the host would be deleted, and new streams for a given domain would have to wait for resolution, it is better to not delete existing hosts; especially since deletion only happens when re-resolving is already in progress. There is no way to disable so the value below is equivalent to 24 hours. Risk Level: low Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is helpful for Google import and shouldn't affect anybody else.