macos: tweak boringssl build config for xcode 9#1785
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 30, 2017
Merged
macos: tweak boringssl build config for xcode 9#1785mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
mattklein123
approved these changes
Sep 30, 2017
Member
mattklein123
left a comment
There was a problem hiding this comment.
Seems reasonable to me. @jmillikin-stripe ?
Contributor
|
LGTM. I confirm this fixes the build on my machine. |
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Remove last remnant associated with Issue [1558](envoyproxy/envoy-mobile#1558) Description: Fully test capitalization with HTTP/1 Risk Level: None Testing: testing only PR Docs Changes: N/A Release Notes: N/A Signed-off-by: Charles Le Borgne <cleborgne@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Remove last remnant associated with Issue [1558](envoyproxy/envoy-mobile#1558) Description: Fully test capitalization with HTTP/1 Risk Level: None Testing: testing only PR Docs Changes: N/A Release Notes: N/A Signed-off-by: Charles Le Borgne <cleborgne@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This PR includes the release notes for v0.5 and the versioning of the docs. **Related Issues/PRs (if applicable)** N/A **Special notes for reviewers (if applicable)** Please review the release notes provided for accuracy and missing key information. --------- Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: Ignasi Barrera <nacx@apache.org> Co-authored-by: Aaron Choo <achoo30@bloomberg.net> Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Xcode 9.0, something related to pthreads and C++ STL has changed. Because boringssl explicitly defines
_POSIX_C_SOURCEthe definitions formach_port_tandpthread_mach_thread_npare omitted when#include <mutex>and#include <ostream>are used, causing compile errors.Specifically setting
_DARWIN_C_SOURCEbrings them back.Signed-off-by: Stephan Zuercher stephan@turbinelabs.io