Skip to content

coverage: revert the limit on http/cache to 92.6.#17817

Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mathetake:revert-http-cache-coverage
Aug 24, 2021
Merged

coverage: revert the limit on http/cache to 92.6.#17817
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mathetake:revert-http-cache-coverage

Conversation

@mathetake
Copy link
Copy Markdown
Member

#17757 seems to cause the coverage failure of http/cache in unrelated PRs(e.g. https://github.com/envoyproxy/envoy/pull/17357/checks?check_run_id=3406159301) and main branch(https://github.com/envoyproxy/envoy/runs/3402140077) so this PR reverts that to 92.6.

cc @alyssawilk

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake requested a review from alyssawilk August 24, 2021 00:38
@mathetake mathetake changed the title coverage: revert the limit http/cache to 92.6. coverage: revert the limit on http/cache to 92.6. Aug 24, 2021
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this also, thanks.

@mattklein123 mattklein123 merged commit eb9f3a9 into envoyproxy:main Aug 24, 2021
@mathetake mathetake deleted the revert-http-cache-coverage branch August 24, 2021 04:04
mpuncel added a commit to mpuncel/envoy that referenced this pull request Aug 25, 2021
* main: (32 commits)
  Stop processing pending H/2 frames if connection transitioned to the closed state
  http2: limit use of deferred resets in the http2 codec to server-side connections
  Abort filter chain iteration on local reply
  Reject or strip fragment from request URI
  ext-authz: merge duplicate headers from client request in check request
  common: introduce stable logger /w examples in DNS  (envoyproxy#17772)
  route: fast return when route matches failed (envoyproxy#17769)
  owners: add owners for dubbo proxy network filter (envoyproxy#17820)
  config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal. (envoyproxy#17724)
  coverage: revert the limit http/cache to 92.6. (envoyproxy#17817)
  network: rename SocketAddressProvider as ConnectionInfoProvider (envoyproxy#17717)
  test: bumping coverage (envoyproxy#17757)
  conn_pool: Minor cleanups to ConnPoolBaseImpl (envoyproxy#17710)
  Split VaryHeader into VaryAllowList and VaryUtils to organize vary-related logic (envoyproxy#17728)
  ext_proc: Make tests more resilient to IPv6 support (envoyproxy#17784)
  Remove invlaid backquote from doc (envoyproxy#17797)
  rocketmq: move to contrib (envoyproxy#17796)
  kafka: upstream kafka facade in mesh-filter (envoyproxy#17783)
  ecds: create shared base class for DynamicFilterConfigProviderImpl (envoyproxy#17735)
  Change log level from debug to trace (envoyproxy#17774)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants