ci: disable OSX due to needing to sort out Circle config issues#1757
Merged
mattklein123 merged 1 commit intomasterfrom Sep 27, 2017
Merged
ci: disable OSX due to needing to sort out Circle config issues#1757mattklein123 merged 1 commit intomasterfrom
mattklein123 merged 1 commit intomasterfrom
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@zuercher @envoyproxy/maintainers |
junr03
approved these changes
Sep 27, 2017
zuercher
approved these changes
Sep 27, 2017
alyssawilk
approved these changes
Sep 27, 2017
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
…yproxy#1757) Signed-off-by: Matt Klein <mklein@lyft.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: A few considerations: - It's critical to set the right environment variables for coverage builds to work (this is how Bazel controls how coverage is run), in particular we need to set CC, CXX, GCOV and BAZEL_LLVM_COV to point to the right tools and they need to exist in the docker container that's running the builds. - BAZEL_USE_LLVM_NATIVE_COVERAGE is required for bazel to run LLVM coverage - These environment variables affect the rbe_autoconfig toolchain generation (i.e. the generated packages will point to different places depending of those env variables), so we need a new toolchain just for coverage. Some shortcomings / gotchas: - Coverage builds depend on config=coverage from upstream Envoy, as such, the coverage actions run locally (probably because remote coverage builds are buggy), because of this we need test_strategy=standalone to run the tests locally and produce the right coverage artifacts. - After my experimentation, coverage builds seem to be incompatible with remote_download_outputs=toplevel (or minimal) so we need to set it to remote_download_outputs=all. Otherwise, some coverage artifacts aren't present locally for the coverage report generation. This is a bug in Bazel and I'll file a bug upstream for that. - Similar experimentation shows that remote caching is also incompatible with remote coverage. For some reason, caching makes prevents some of the coverage artifacts to be present locally and the report generation consistently fails. This is another bug from Bazel (I'll file another issue for this). Last, I've added a remote-ci-debug config to print various different streams of data from different Bazel stages Risk Level: Low Testing: See coverage workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: A few considerations: - It's critical to set the right environment variables for coverage builds to work (this is how Bazel controls how coverage is run), in particular we need to set CC, CXX, GCOV and BAZEL_LLVM_COV to point to the right tools and they need to exist in the docker container that's running the builds. - BAZEL_USE_LLVM_NATIVE_COVERAGE is required for bazel to run LLVM coverage - These environment variables affect the rbe_autoconfig toolchain generation (i.e. the generated packages will point to different places depending of those env variables), so we need a new toolchain just for coverage. Some shortcomings / gotchas: - Coverage builds depend on config=coverage from upstream Envoy, as such, the coverage actions run locally (probably because remote coverage builds are buggy), because of this we need test_strategy=standalone to run the tests locally and produce the right coverage artifacts. - After my experimentation, coverage builds seem to be incompatible with remote_download_outputs=toplevel (or minimal) so we need to set it to remote_download_outputs=all. Otherwise, some coverage artifacts aren't present locally for the coverage report generation. This is a bug in Bazel and I'll file a bug upstream for that. - Similar experimentation shows that remote caching is also incompatible with remote coverage. For some reason, caching makes prevents some of the coverage artifacts to be present locally and the report generation consistently fails. This is another bug from Bazel (I'll file another issue for this). Last, I've added a remote-ci-debug config to print various different streams of data from different Bazel stages Risk Level: Low Testing: See coverage workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Previously the MCPProxy struct was create per request, which caused a recreation of http client for example, and resulted in not reusing the connection pool. This did not result in a noticeable benchmark result diff but it will improve the perf in majority of use cases. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Co-authored-by: Ignasi Barrera <ignasi@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Klein mklein@lyft.com