ext_proc: Implement BUFFERED_PARTIAL processing mode#17531
Merged
snowp merged 7 commits intoenvoyproxy:mainfrom Aug 4, 2021
Merged
ext_proc: Implement BUFFERED_PARTIAL processing mode#17531snowp merged 7 commits intoenvoyproxy:mainfrom
snowp merged 7 commits intoenvoyproxy:mainfrom
Conversation
Implement the final unimplemented processing mode, which sends the body in a single chunk if the entire body can be processed without exceeding the buffer limit, or sends a chunk containing only the part of the body that fits within the limit otherwise. Signed-off-by: Gregory Brail <gregbrail@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Gregory Brail <gregbrail@google.com>
Signed-off-by: Gregory Brail <gregbrail@google.com>
Signed-off-by: Gregory Brail <gregbrail@google.com>
Contributor
|
/lgtm api |
snowp
suggested changes
Aug 2, 2021
Contributor
snowp
left a comment
There was a problem hiding this comment.
Makes sense to me, just a few comments
Do we have any docs on when one might want to use buffered_partial vs other modes?
test/extensions/filters/http/ext_proc/ext_proc_integration_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/filters/http/ext_proc/ext_proc_integration_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Gregory Brail <gregbrail@google.com>
Signed-off-by: Gregory Brail <gregbrail@google.com>
snowp
approved these changes
Aug 3, 2021
Contributor
snowp
left a comment
There was a problem hiding this comment.
Thanks!
I think you'll need to merge main to fix CI
/wait
Signed-off-by: Gregory Brail <gregbrail@google.com>
Contributor
Author
|
Looks like CI is fixed with the latest merge. |
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Aug 4, 2021
…bridge-stream * upstream/main: (32 commits) tls: move ssl connection info into SocketAddressProvider (envoyproxy#17334) conn pool: default enable runtime feature `conn_pool_delete_when_idle` (envoyproxy#17577) api: LEDS api introduction (envoyproxy#17419) kafka: add support for api versions request in mesh-filter (envoyproxy#17475) ext_proc: Implement BUFFERED_PARTIAL processing mode (envoyproxy#17531) tooling: Async/pathlib/mypy cleanups and utils (envoyproxy#17505) xds: restructure CertificateProvider fields (envoyproxy#17201) Refactor OverloadIntegrationTest breaking out a test base, and the fake resource monitors. (envoyproxy#17530) listener: move active connection collection out of active tcp listener (envoyproxy#16947) tools: format checks for backticks (envoyproxy#17566) coverage: set lower limit for common/quic and common (envoyproxy#17573) v2: final source removal (envoyproxy#17565) test: bumping coverage (envoyproxy#17564) quic: enforcing header size and contents (envoyproxy#17520) Support for canonicalizing URI properly for AWS SigV4 signer (envoyproxy#17137) listener: add a stat for transport socket connect timeout (envoyproxy#17458) listener: add listen() error handling (envoyproxy#17427) http: return per route config when direct response is set (envoyproxy#17449) removing most v2 references from source/ (envoyproxy#17415) bug fix: return bootstrap when validating config (envoyproxy#17499) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Implement the final unimplemented processing mode, which sends the body in a single chunk if the entire body can be processed without exceeding the buffer limit, or sends a chunk containing only the part of the body that fits within the limit otherwise. Signed-off-by: Gregory Brail <gregbrail@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Implement the final unimplemented processing mode, which sends the
body in a single chunk if the entire body can be processed without
exceeding the buffer limit, or sends a chunk containing only the
part of the body that fits within the limit otherwise.
Additional Description: All of the processing modes defined by the filter are now implemented
Risk Level: Medium -- only affects code that turns it on
Testing: New integration and unit tests added.