tcp proxy: connect to upstream when downstream connections#175
Merged
mattklein123 merged 3 commits intomasterfrom Oct 28, 2016
Merged
tcp proxy: connect to upstream when downstream connections#175mattklein123 merged 3 commits intomasterfrom
mattklein123 merged 3 commits intomasterfrom
Conversation
The previous behavior was to connect only when data is received on the downstream connection. Unfortunately this breaks protocols which connect and the server is the first half to send data (e.g., mysql). This required a refactor to handle the case where we immediately disconnect downstream during network filter chain creation. This commit also cleans up the filter factory functions so that they take a filter manager interface vs. a connection interface to force filters to operate via the filter callbacks.
Member
Author
|
cc @lyft/network-team @enricoschiattarella |
RomanDzhabarov
approved these changes
Oct 28, 2016
Member
RomanDzhabarov
left a comment
There was a problem hiding this comment.
One question, lgtm otherwise
| parent_.num_connections_++; | ||
|
|
||
| // If the connection is already closed, we can just let this connection immediately die. | ||
| if (new_connection->state() != Network::Connection::State::Closed) { |
Member
There was a problem hiding this comment.
should we also rule out State::Closing here? (do only for State::Open)
Member
Author
There was a problem hiding this comment.
No, that was on purpose, to allow for write flushing if needed.
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
zh-translation:/intro/arch_overview/security/ssl.rst
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Fixes #175 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Fixes #175 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message**: This fixes the placement of `ignore` section in dependabot.yml. **Related Issues/PRs (if applicable)**: Follow up on #174 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behavior was to connect only when data is received on the
downstream connection. Unfortunately this breaks protocols which connect
and the server is the first half to send data (e.g., mysql).
This required a refactor to handle the case where we immediately disconnect
downstream during network filter chain creation.
This commit also cleans up the filter factory functions so that they take a
filter manager interface vs. a connection interface to force filters to
operate via the filter callbacks.