Skip to content

ci: fix coverage and alpine image#1749

Merged
mattklein123 merged 4 commits intomasterfrom
ci_fixes
Sep 26, 2017
Merged

ci: fix coverage and alpine image#1749
mattklein123 merged 4 commits intomasterfrom
ci_fixes

Conversation

@mattklein123
Copy link
Copy Markdown
Member

Signed-off-by: Matt Klein mklein@lyft.com

Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
junr03
junr03 previously approved these changes Sep 26, 2017
Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123 mattklein123 merged commit b02d8a9 into master Sep 26, 2017
@mattklein123 mattklein123 deleted the ci_fixes branch September 26, 2017 20:31
costinm pushed a commit to costinm/envoy that referenced this pull request Oct 2, 2017
Signed-off-by: Matt Klein <mklein@lyft.com>
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake pushed a commit that referenced this pull request Mar 3, 2026
**Description**
AWS supports Service tiers similar to Openai[1]. Following the service
tier definition based off the converse API[2].

Updated translation for openai -> aws bedrock in the request body and
response body. Updated the tests to tests translations.

1.
https://docs.aws.amazon.com/bedrock/latest/userguide/service-tiers-inference.html
2.
https://docs.aws.amazon.com/bedrock/latest/APIReference/API_runtime_Converse.html

Successful setting of service_body will return:
```
{..., "service_tier":"default", ...}
```

A **valid** service tier that is unsupported for the model will return a
400:
```
{"type":"error","error":{"type":"ValidationException:http://internal.amazon.com/coral/com.amazon.bedrock/","code":"400","message":"Reservation not found."}}
```
Only specific models have support for reserved.


Dropped openai.ChatCompletionNewParamsServiceTier in favour of string to
keep consistent with the other definitions of service_tier in that file

---------

Signed-off-by: achoo30 <achoo30@bloomberg.net>
Signed-off-by: Aaron Choo <achoo30@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants