test: Fix admission control integration test flakiness#17114
Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom Jun 28, 2021
Merged
test: Fix admission control integration test flakiness#17114alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
Conversation
Contributor
|
Hm, something looks unhappy. Will tag as waiting until you've had a chance to check out CI! |
Signed-off-by: Tony Allen <tony@allen.gg>
antoniovicente
approved these changes
Jun 25, 2021
alyssawilk
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix admission control integration test flakiness
Merging #16742 added the default upper-bound of 80% on rejection probability, which results in a slower convergence of the observed rejection rate to what we expect. I hacked up a script to see the variability of the error for 300 requests across 1000 tests:
As the upper-bound drops, the variance in observed errors increases. I expect there to have been around ~20% flakiness in those tests since the patch was merged. Increasing the allowed error to 10% as you did in #17084 would still probably yield some flakiness...
I think the best option here is to just increase the rejection upper-bound to 100% in the test and leave the allowed absolute error at 10% to put this thing to rest.
This is a test-only change, so foregoing most of the template.
Fixes #17067