Skip to content

regex: remove parseStdRegexAsCompiledMatcher#17061

Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
daixiang0:parse
Jun 21, 2021
Merged

regex: remove parseStdRegexAsCompiledMatcher#17061
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
daixiang0:parse

Conversation

@daixiang0
Copy link
Copy Markdown
Member

Signed-off-by: Long Dai long0dai@foxmail.com

Commit Message:

Remove useless func, now it is only used in test:

root:[envoy]$ git grep parseStdRegexAsCompiledMatcher
source/common/common/regex.cc:130:CompiledMatcherPtr Utility::parseStdRegexAsCompiledMatcher(const std::string& regex,
source/common/common/regex.h:36:  parseStdRegexAsCompiledMatcher(const std::string& regex,
test/common/common/regex_test.cc:20:  EXPECT_THROW_WITH_REGEX(Utility::parseStdRegexAsCompiledMatcher("(+invalid)"), EnvoyException,
test/common/common/regex_test.cc:38:    auto matcher = Utility::parseStdRegexAsCompiledMatcher(

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Long Dai <long0dai@foxmail.com>
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@alyssawilk alyssawilk merged commit e949791 into envoyproxy:main Jun 21, 2021
@daixiang0 daixiang0 deleted the parse branch June 22, 2021 00:26
alyssawilk pushed a commit that referenced this pull request Jul 1, 2021
Increase common/common coverage by:

Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher #17061
Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
Increase common/common coverage by:

Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher envoyproxy#17061
Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Remove useless func, now it is only used in test:

Signed-off-by: Long Dai <long0dai@foxmail.com>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Increase common/common coverage by:

Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher envoyproxy#17061
Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants