Call c_str for regex ctor to resolve local string compat issues.#1694
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Sep 19, 2017
Merged
Call c_str for regex ctor to resolve local string compat issues.#1694htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
htuch
previously approved these changes
Sep 19, 2017
3c76588 to
f0daf4b
Compare
Signed-off-by: Trevor Schroeder <trevors@abnormal.cam.corp.google.com>
f0daf4b to
fe009e2
Compare
htuch
approved these changes
Sep 19, 2017
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Envoy Gateway skips the weight zero backendRef when constructing localityLbEndoints slices. This starts handling such cases gracefully rather than taking them as errors. **Related Issues/PRs (if applicable)** Close #1664 Supersedes #1694 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve any incompatibilities between std::string and local string (versa_string in this case) by instead passing c_str() to std::regex ctor.
@htuch