Closed
Conversation
Member
Author
|
@caniszczyk I looked and this still seems like the best way. |
Member
Author
|
And ... I failed my own test. This kind of sucks for editing within the GH UI. Oh well. |
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
And failed again |
Signed-off-by: Matt Klein <mklein@lyft.com>
Contributor
|
@mattklein123 it super sucks you can't use the GitHub UI to enforce signed-off-by, so you have to use a client (been working with GitHub to enable this via their web ui but no dice yet) |
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This commit adds an additional safeguard for older deployment regarding the OpenAI prefix configuration added in #1666. More specifically, this prevents an issue that could happen in a small window when the old extproc is running while the extproc config gets updated by the new controller. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1663