Skip to content

quiche: disable quic_http_integration_test under coverage#16534

Merged
antoniovicente merged 5 commits intoenvoyproxy:mainfrom
danzh2010:disablecoveragetest
May 19, 2021
Merged

quiche: disable quic_http_integration_test under coverage#16534
antoniovicente merged 5 commits intoenvoyproxy:mainfrom
danzh2010:disablecoveragetest

Conversation

@danzh2010
Copy link
Copy Markdown
Contributor

Signed-off-by: Dan Zhang danzh@google.com

Commit Message: this test flakies in coverage CI: https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/75714/logs/287

Signed-off-by: Dan Zhang <danzh@google.com>
@danzh2010
Copy link
Copy Markdown
Contributor Author

/assign @antoniovicente @snowp

@antoniovicente
Copy link
Copy Markdown
Contributor

Related issues: #16493 and #16335

@antoniovicente
Copy link
Copy Markdown
Contributor

Please look at and update coverage expectations.

2021-05-17T22:40:40.7123374Z Per-extension coverage failed:
2021-05-17T22:40:40.7124459Z Code coverage for source/common is lower than limit of 96.3 (96.2)
2021-05-17T22:40:40.7125142Z Code coverage for source/common/quic is lower than limit of 87.4 (84.9)
2021-05-17T22:40:40.7125625Z Code coverage for source/common/network is lower than limit of 95.0 (94.9)
2021-05-17T22:40:40.7126123Z Code coverage for source/extensions/resource_monitors is lower than limit of 96.6 (95.8)
2021-05-17T22:40:40.7126643Z Code coverage for source/extensions/resource_monitors/common is lower than limit of 96.6 (70.0)
2021-05-17T22:40:40.7127653Z Code coverage for source/server is lower than limit of 94.4 (94.2)

Signed-off-by: Dan Zhang <danzh@google.com>
@alyssawilk
Copy link
Copy Markdown
Contributor

(coverage is still failing)
Is this the same test failing on tsan? can we disable specific test cases instead of the entire thing?

danzh1989 added 3 commits May 18, 2021 10:48
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
@danzh2010
Copy link
Copy Markdown
Contributor Author

(coverage is still failing)
Is this the same test failing on tsan? can we disable specific test cases instead of the entire thing?

Disabling the whole test suite lower the coverage a lot. I changed to disable the giant request/response tests instead. These likely were the ones that caused the coverage CI to fail.

@antoniovicente
Copy link
Copy Markdown
Contributor

(coverage is still failing)
Is this the same test failing on tsan? can we disable specific test cases instead of the entire thing?

We're having trouble getting info on which test cases were failing in the coverage build. Would be good to gather more information about failing test cases if possible.

Copy link
Copy Markdown
Contributor

@antoniovicente antoniovicente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@antoniovicente antoniovicente merged commit 84138f7 into envoyproxy:main May 19, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
…gration_test under coverage (envoyproxy#16534)

Signed-off-by: Dan Zhang <danzh@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants