Conversation
| wget https://github.com/gabime/spdlog/archive/v0.11.0.tar.gz | ||
| tar xf v0.11.0.tar.gz | ||
| rm v0.11.0.tar.gz | ||
| mv spdlog-0.11.0 spdlog |
Member
There was a problem hiding this comment.
let's leave as spdlog-0.11.0 and update do_ci.sh to point to this directory.
mattklein123
approved these changes
Oct 20, 2016
Member
mattklein123
left a comment
There was a problem hiding this comment.
please push new build image once merged
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Feb 28, 2020
* Delay sendLocalReply till after the call to prevent rentrant calls. (envoyproxy#432) Signed-off-by: John Plevyak <jplevyak@gmail.com> * Add missing deferred operation handlers. Signed-off-by: John Plevyak <jplevyak@gmail.com>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…filter zh-translation: docs/root/intro/arch_overview/security/ext_authz_filt…
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
We're not yet able to have specific kotlin and java directory specific rules just yet because of the transitive dependency problem highlighted in the comment. Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: move aar build specific rules into the `library/BUILD` Risk Level: low Testing: ci, local Docs Changes: na Release Notes: na [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
We're not yet able to have specific kotlin and java directory specific rules just yet because of the transitive dependency problem highlighted in the comment. Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: move aar build specific rules into the `library/BUILD` Risk Level: low Testing: ci, local Docs Changes: na Release Notes: na [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Co-authored-by: José Carlos Chávez <jcchavezs@gmail.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
closes #147 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested this by making a new
lyft/envoy-buildimage and compiling withdocker run -t -i -v <SOURCE_DIR>:/source lyft/envoy-build:latest /bin/bash -c "cd /source && ci/do_ci.sh normal"I'll push to dockerhub once we merge this.