installs and uses python3 and pip3 on frontproxy service example#1617
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 11, 2017
Merged
Conversation
Member
|
Is it possible to add CI for this regression so we don't break again? |
Member
|
We used to have example verification as part of CI but it got commented out due to CI times being too long and flakey. IMO we can live with this situation until we get a better CI that runs faster. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: This fixes up #1617. The "DirectResponse" test mechanism is super brittle and sensitive to indentation changes. I very much want to go and clean it up once config phase 3 ships, since that will provide a saner path. Risk Level: Moderate Testing: CI & Local Co-authored-by: alyssawilk <alyssar@chromium.org> Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: This fixes up #1617. The "DirectResponse" test mechanism is super brittle and sensitive to indentation changes. I very much want to go and clean it up once config phase 3 ships, since that will provide a saner path. Risk Level: Moderate Testing: CI & Local Co-authored-by: alyssawilk <alyssar@chromium.org> Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This removes the unused function in tracer implementation for image generation endpoint. **Related Issues/PRs (if applicable)** This is a follow up on #1280 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1597
Could also incorporate the instructions on https://github.com/docker-library/python/blob/master/3.5/jessie/Dockerfile, though this might be overkill. 😄