Revert "honour routes timeout if max stream duration is set with out …#16133
Merged
snowp merged 1 commit intoenvoyproxy:mainfrom Apr 23, 2021
Merged
Revert "honour routes timeout if max stream duration is set with out …#16133snowp merged 1 commit intoenvoyproxy:mainfrom
snowp merged 1 commit intoenvoyproxy:mainfrom
Conversation
…stream duration (envoyproxy#15585)" This reverts commit ffa1680. Signed-off-by: Snow Pettersen <snowp@lyft.com>
htuch
approved these changes
Apr 23, 2021
Contributor
Author
|
Marked for backporting to 1.8.2 |
Contributor
Contributor
Contributor
|
@dmitri-d Any suggestions on timelines for this backport? |
Contributor
|
@ramaraochavali: will port on Monday, May 3rd. |
Contributor
|
On Sat, 1 May 2021 at 10:01 PM, Dmitri Dolguikh ***@***.***> wrote:
@ramaraochavali <https://github.com/ramaraochavali>: will port on Monday,
May 3rd.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEDINKHXCY53KNXWFYAURK3TLQUERANCNFSM43NRNKWQ>
.
Thank you so much
|
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…stream duration (envoyproxy#15585)" (envoyproxy#16133) This reverts commit ffa1680. Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…stream duration (#15585)"
This reverts commit ffa1680.
Per #16129
Signed-off-by: Snow Pettersen snowp@lyft.com