protos: Remove (more) redundant imports#16086
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
it would be really good if we could stop these being added (cf #15589 ) im wondering if any of the protobuf linters might work |
Signed-off-by: Ryan Northey <ryan@synca.io>
htuch
left a comment
There was a problem hiding this comment.
Can we add some way to catch regressions here as a CI check?
i very much hope so the main issue i think is that we cant fail on the warnings (there are other unrelated warnings - also this issue can come from upstream protos) - which is why im thinking that using a proto linter is the way forward (hopefully that would catch these issues) |
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Gokul Nair <gnair@twitter.com>
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: protos: Remove (more) redundant imports
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]