upgrade rules_go to v0.27.0 (#16065)#16083
Merged
lizan merged 3 commits intoenvoyproxy:mainfrom Apr 21, 2021
Merged
Conversation
|
Hi @QIvan, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
2ce5383 to
c1bc106
Compare
in the resent version of rules_go, the issue bazel-contrib/rules_go#2771 was fixed. It should address the bazel build issue on some Linux or MacOS (bazelbuild/bazel#12986) Signed-off-by: Ivan Zemlyanskiy <qtivan@gmail.com>
Contributor
|
I've been running this in my environments since it was released |
Contributor
|
Might be too late but might be good to bump the Go version to |
Signed-off-by: izemlyanskiy <izemlyanskiy@pulsepoint.com>
Contributor
Author
|
@moderation done (see the last commit) |
Contributor
Author
|
hmmmm... after go upgrade it complains like ERROR: /build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/external/com_github_lyft_protoc_gen_star/BUILD.bazel:3:11: GoCompilePkg external/com_github_lyft_protoc_gen_star/protoc-gen-star.a failed (Exit 1): builder failed: error executing command
(cd /build/tmp/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/execroot/envoy && \
exec env - \
CGO_ENABLED=1 \
GOARCH=amd64 \
GOOS=linux \
GOPATH='' \
GOROOT=external/go_sdk \
GOROOT_FINAL=GOROOT \
PATH=/opt/llvm/bin:/usr/bin:/bin \
bazel-out/host/bin/external/go_sdk/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src external/com_github_lyft_protoc_gen_star/artifact.go -src external/com_github_lyft_protoc_gen_star/ast.go -src external/com_github_lyft_protoc_gen_star/build_context.go -src external/com_github_lyft_protoc_gen_star/comment.go -src external/com_github_lyft_protoc_gen_star/debug.go -src external/com_github_lyft_protoc_gen_star/docs.go -src external/com_github_lyft_protoc_gen_star/entity.go -src external/com_github_lyft_protoc_gen_star/enum.go -src external/com_github_lyft_protoc_gen_star/enum_value.go -src external/com_github_lyft_protoc_gen_star/extension.go -src external/com_github_lyft_protoc_gen_star/field.go -src external/com_github_lyft_protoc_gen_star/field_type.go -src external/com_github_lyft_protoc_gen_star/field_type_elem.go -src external/com_github_lyft_protoc_gen_star/file.go -src external/com_github_lyft_protoc_gen_star/generator.go -src external/com_github_lyft_protoc_gen_star/init_option.go -src external/com_github_lyft_protoc_gen_star/message.go -src external/com_github_lyft_protoc_gen_star/method.go -src external/com_github_lyft_protoc_gen_star/module.go -src external/com_github_lyft_protoc_gen_star/name.go -src external/com_github_lyft_protoc_gen_star/node.go -src external/com_github_lyft_protoc_gen_star/oneof.go -src external/com_github_lyft_protoc_gen_star/package.go -src external/com_github_lyft_protoc_gen_star/parameters.go -src external/com_github_lyft_protoc_gen_star/persister.go -src external/com_github_lyft_protoc_gen_star/post_process.go -src external/com_github_lyft_protoc_gen_star/proto.go -src external/com_github_lyft_protoc_gen_star/service.go -src external/com_github_lyft_protoc_gen_star/source_code_info.go -src external/com_github_lyft_protoc_gen_star/wkt.go -src external/com_github_lyft_protoc_gen_star/workflow.go -arc 'github.com/golang/protobuf/proto=github.com/golang/protobuf/proto=bazel-out/host/bin/external/com_github_golang_protobuf/proto/proto.x' -arc 'github.com/golang/protobuf/protoc-gen-go/plugin=github.com/golang/protobuf/protoc-gen-go/plugin=bazel-out/host/bin/external/io_bazel_rules_go/proto/wkt/compiler_plugin_go_proto.x' -arc 'github.com/golang/protobuf/protoc-gen-go/descriptor=github.com/golang/protobuf/protoc-gen-go/descriptor=bazel-out/host/bin/external/io_bazel_rules_go/proto/wkt/descriptor_go_proto.x' -importpath github.com/lyft/protoc-gen-star -p github.com/lyft/protoc-gen-star -package_list bazel-out/host/bin/external/go_sdk/packages.txt -o bazel-out/host/bin/external/com_github_lyft_protoc_gen_star/protoc-gen-star.a -x bazel-out/host/bin/external/com_github_lyft_protoc_gen_star/protoc-gen-star.x -gcflags '' -asmflags '')
Execution platform: @rbe_ubuntu_clang_libcxx//config:platform
compilepkg: missing strict dependencies:
/b/f/w/external/com_github_lyft_protoc_gen_star/init_option.go: import of "github.com/spf13/afero"
/b/f/w/external/com_github_lyft_protoc_gen_star/persister.go: import of "github.com/spf13/afero"
No dependencies were provided.seems like it's not an easy change. I'll revert the last commit |
This reverts commit b91ea2d. Signed-off-by: izemlyanskiy <izemlyanskiy@pulsepoint.com>
Contributor
|
I'm guessing this is a change in module handling in Go 1.16. I'm building the API and the binary and it works but it is with a subset of extensions compiled in. Can we bump to 1.15.11 which is the latest Go version that should be compatible? |
membphis
approved these changes
Apr 21, 2021
lizan
approved these changes
Apr 21, 2021
Contributor
Author
|
@moderation sorry, didn't get in time with the change... |
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
in the resent version of rules_go, the issue bazel-contrib/rules_go#2771 was fixed. It should address the bazel build issue on some Linux or MacOS (bazelbuild/bazel#12986) Signed-off-by: izemlyanskiy <izemlyanskiy@pulsepoint.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the resent version of rules_go, the issue bazel-contrib/rules_go#2771 was fixed.
It should address the bazel build issue on some Linux or MacOS (bazelbuild/bazel#12986)