[fuzz] exclude unknown security extensions from fuzz tests#16074
[fuzz] exclude unknown security extensions from fuzz tests#16074asraa wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
htuch
left a comment
There was a problem hiding this comment.
Thanks for doing this, it will also save us on chasing down bugs in unsupported filters. Question on method..
| # Extensions with unknown security posture. This will be kept in sync by CI. | ||
| # This is used to exclude while fuzzing. | ||
| UNKNOWN_SECURITY_EXTENSIONS = [ | ||
| "envoy.access_loggers.wasm", |
There was a problem hiding this comment.
Can we do this differently? In the fuzz rule, can we make use of the security posture information somehow and nop it? Just worried about maintainability and single SoT.
There was a problem hiding this comment.
Ah, right it's checked validated in CI against security posture info.
I get that, I wasn't sure at all how to reflect back on the status information from the extensions, but mostly want to block CI asap. If you have a Bazel docs link (or example?) please link!
There was a problem hiding this comment.
How about having
Line 115 in a809844
I think we want this anyway, since when we add the "secure profile", we want to refuse to initialize if any insecure extensions are linked. LMK if this seems too much time given the desire to land something soon, but it seems the most robust for future needs.
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com> Commit Message: Temporary CI fix before envoyproxy#16074 Risk Level: Low Testing: Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: Gokul Nair <gnair@twitter.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Asra Ali asraa@google.com
Commit Message: exclude extensions with unknown extensions from fuzz tests
Additional Description: this hopefully will help gcc builds that are breaking with too many args.