Bring parity to the docker images on the install docs pages#16038
Merged
asraa merged 3 commits intoenvoyproxy:mainfrom Apr 22, 2021
Merged
Bring parity to the docker images on the install docs pages#16038asraa merged 3 commits intoenvoyproxy:mainfrom
asraa merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
cc @phlax and @envoyproxy/windows-dev |
pravb
reviewed
Apr 16, 2021
pravb
previously approved these changes
Apr 16, 2021
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
asraa
reviewed
Apr 20, 2021
Contributor
asraa
left a comment
There was a problem hiding this comment.
Do you want to add envoy-windows release image to the table below? https://github.com/envoyproxy/envoy/blob/8fc2acd074520e5aaf34b60591e715fc29db385e/docs/root/start/install.rst#pre-built-envoy-docker-images
Member
|
+1 good spot - heres the (currently) rendered version https://storage.googleapis.com/envoy-pr/8fc2acd/docs/start/install.html#pre-built-envoy-docker-images |
Member
Author
|
good point, let me add that |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
Just updated |
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…xy#16038) * Bring parity to the docker images in the install docs pages Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:
As pointed out on the Windows sections we only linked to the dev images in
install.rst. This should not be the case for official releases. We resolve it with using the|envoy_windows_docker_image|substitution block.Risk Level: N/A docs only
Testing: N/A
Docs Changes: Only docs
Release Notes: N/A
Platform Specific Features: N/A