tooling: Add all pytests checker#16031
Merged
htuch merged 9 commits intoenvoyproxy:mainfrom Apr 22, 2021
Merged
Conversation
Member
Author
|
coverage is here https://storage.googleapis.com/envoy-pr/16031/tooling/index.html |
5775881 to
2bbdb25
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
df92aab to
6df3b26
Compare
htuch
suggested changes
Apr 21, 2021
Member
htuch
left a comment
There was a problem hiding this comment.
Looks good, a few small comments.
/wait
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
htuch
reviewed
Apr 22, 2021
| call_args = (("--",) + args) if args else args | ||
| bazel_args = ("bazel", "run", "BAZEL RUN") + call_args | ||
| bazel_kwargs = {} | ||
| bazel_kwargs["capture_output"] = ( |
Member
Author
There was a problem hiding this comment.
this is checking the default - ie unless its specifically set to True then it should False
Member
There was a problem hiding this comment.
I see. I probably would have gone with capture_output or False, but sure.
phlax
commented
Apr 22, 2021
| self, | ||
| target: str, | ||
| *args, | ||
| capture_output: bool = False, |
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
another breakout from envoyproxy#15833 Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Gokul Nair <gnair@twitter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: tooling: Add all pytests checker
Additional Description:
another breakout from #15833
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]