Skip to content

listener: add optional stat_prefix to use instead of listener address#15951

Merged
ggreenway merged 1 commit intoenvoyproxy:mainfrom
ggreenway:listener-stat-prefix
Apr 13, 2021
Merged

listener: add optional stat_prefix to use instead of listener address#15951
ggreenway merged 1 commit intoenvoyproxy:mainfrom
ggreenway:listener-stat-prefix

Conversation

@ggreenway
Copy link
Copy Markdown
Member

Commit Message:
Additional Description:
Risk Level: Low
Testing: Added unit test
Docs Changes: added
Release Notes: added
Platform Specific Features: none
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #15951 was opened by ggreenway.

see: more, trace.

Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway ggreenway force-pushed the listener-stat-prefix branch from 19d77e9 to 706bdc5 Compare April 13, 2021 15:39
@ggreenway
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15951 (comment) was created by @ggreenway.

see: more, trace.

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ggreenway ggreenway merged commit 8771f7f into envoyproxy:main Apr 13, 2021
douglas-reid pushed a commit to douglas-reid/envoy that referenced this pull request Apr 19, 2021
…envoyproxy#15951)

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Monkeyanator pushed a commit to Monkeyanator/envoy that referenced this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants