Skip to content

Use ABSL_GUARDED_BY everywhere#15945

Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
justin-mp:missing-absl-prefix
Apr 14, 2021
Merged

Use ABSL_GUARDED_BY everywhere#15945
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
justin-mp:missing-absl-prefix

Conversation

@justin-mp
Copy link
Copy Markdown
Contributor

For some reason struct MemFileInfo only used GUARDED_BY instead of
ABSL_GUARDED_BY.

Signed-off-by: Justin Mazzola Paluska justinmp@google.com

Risk Level: Low
Testing: bazel build //test/test_common:file_system_for_test_lib
Docs Changes: N/A
Release Notes: N/A

For some reason struct MemFileInfo only used GUARDED_BY instead of
ABSL_GUARDED_BY.

Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>
@htuch
Copy link
Copy Markdown
Member

htuch commented Apr 13, 2021

/assign-from @envoyproxy/maintainers

@repokitteh-read-only
Copy link
Copy Markdown

@envoyproxy/maintainers assignee is @jmarantz

🐱

Caused by: a #15945 (comment) was created by @htuch.

see: more, trace.

@yanavlasov yanavlasov merged commit 5b1977f into envoyproxy:main Apr 14, 2021
@justin-mp justin-mp deleted the missing-absl-prefix branch April 15, 2021 11:49
douglas-reid pushed a commit to douglas-reid/envoy that referenced this pull request Apr 19, 2021
For some reason struct MemFileInfo only used GUARDED_BY instead of
ABSL_GUARDED_BY.

Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Monkeyanator pushed a commit to Monkeyanator/envoy that referenced this pull request Apr 20, 2021
For some reason struct MemFileInfo only used GUARDED_BY instead of
ABSL_GUARDED_BY.

Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants