Construct empty string from "" not nullptr#15930
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom Apr 13, 2021
Merged
Conversation
When building locally, I got a clang-tidy error saying that “constructing string from nullptr is undefined behaviour”. Indeed, as far as I can tell, it is. https://groups.google.com/a/isocpp.org/g/std-proposals/c/PGdx39Iy8pg Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>
lizan
approved these changes
Apr 13, 2021
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
When building locally, I got a clang-tidy error saying that “constructing string from nullptr is undefined behaviour”. Indeed, as far as I can tell, it is. https://groups.google.com/a/isocpp.org/g/std-proposals/c/PGdx39Iy8pg Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building locally, I got a clang-tidy error saying that
“constructing string from nullptr is undefined behaviour”. Indeed, as
far as I can tell, it is.
https://groups.google.com/a/isocpp.org/g/std-proposals/c/PGdx39Iy8pg
Signed-off-by: Justin Mazzola Paluska justinmp@google.com
Risk Level: Low
Testing: bazel test //test/extensions/filters/http/grpc_json_transcoder/...
Docs Changes: N/A
Release Notes: N/A