Skip to content

Clean up unnecessary crumbs#15927

Merged
lizan merged 1 commit intoenvoyproxy:mainfrom
wrowe:clean-crumbs
Apr 13, 2021
Merged

Clean up unnecessary crumbs#15927
lizan merged 1 commit intoenvoyproxy:mainfrom
wrowe:clean-crumbs

Conversation

@wrowe
Copy link
Copy Markdown
Contributor

@wrowe wrowe commented Apr 12, 2021

Commit Message: Clean up unnecessary crumbs
Additional Description:

  • mop up nohup.out crumb left over from PR 15374
  • clean up noop flags from macos build per lizan from PR 15877

Risk Level: N/A
Testing: CI
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

- mop up nohup.out crumb left over from PR 15374
- clean up noop flags from macos build per lizan from PR 15877

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
@wrowe wrowe requested a review from lizan April 12, 2021 16:20
@wrowe
Copy link
Copy Markdown
Contributor Author

wrowe commented Apr 12, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15927 (comment) was created by @wrowe.

see: more, trace.

@wrowe
Copy link
Copy Markdown
Contributor Author

wrowe commented Apr 13, 2021

Looking good-to-merge, @lizan - the skipped macos test presubmit ran to completion.

@wrowe wrowe mentioned this pull request Apr 13, 2021
@lizan lizan merged commit a8f0386 into envoyproxy:main Apr 13, 2021
@wrowe wrowe deleted the clean-crumbs branch April 13, 2021 20:28
Monkeyanator pushed a commit to Monkeyanator/envoy that referenced this pull request Apr 20, 2021
- mop up nohup.out crumb left over from PR 15374
- clean up noop flags from macos build per lizan from PR 15877

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants