Skip to content

deps: update libcurl to 7.76.0.#15925

Merged
htuch merged 2 commits intoenvoyproxy:mainfrom
htuch:libcurl-bump
Apr 13, 2021
Merged

deps: update libcurl to 7.76.0.#15925
htuch merged 2 commits intoenvoyproxy:mainfrom
htuch:libcurl-bump

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Apr 12, 2021

Also fix CPE to point at libcurl rather than curl.

Signed-off-by: Harvey Tuch htuch@google.com

Also fix CPE to point at libcurl rather than curl.

Signed-off-by: Harvey Tuch <htuch@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #15925 was opened by htuch.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 12, 2021
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Apr 12, 2021

@wrowe can you take a look at this from patch perspective?

wrowe
wrowe previously approved these changes Apr 12, 2021
Copy link
Copy Markdown
Contributor

@wrowe wrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to see CI results.

moderation
moderation previously approved these changes Apr 12, 2021
@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Apr 12, 2021
@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented Apr 12, 2021

@htuch it's on you to bump the date back one day

com_github_curl has a GitHub release date 2021-03-30
An error occurred while processing ./bazel/repository_locations.bzl, please verify the correctness of the metadata: Mismatch with metadata release date of 2021-03-31
##[error]Bash exited with code '1'.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch dismissed stale reviews from moderation and wrowe via 5fac5de April 12, 2021 23:19
@repokitteh-read-only repokitteh-read-only bot added deps Approval required for changes to Envoy's external dependencies and removed waiting labels Apr 12, 2021
@moderation
Copy link
Copy Markdown
Contributor

The way the release date is retrieved today at https://github.com/envoyproxy/envoy/blob/main/tools/dependency/release_dates.py#L58-L69 is incorrect. It says the release date is the that of the latest commit. However releases can be cut at times later than the last commit and this release date is what is shown in the UI. For this curl release the actual UTC release date is 2021-03-31

Here is my code that makes a different API call to get the actual UTC release date:

# Extract release date from GitHub API.
def get_release_date(repo, metadata_version, github_release):
    if github_release.tagged:

        try:
            latest = repo.get_latest_release()
        except github.GithubException as e:
            # print(Fore.RED + 'GitHub API status get_latest_release(): {}'.format(str(e)) + Style.RESET_ALL)
            latest = ''
            pass

        if latest and (github_release.version <= latest.tag_name):
            # print("latest.tag_name: ", latest.tag_name)
            # print("github_release.version: ", github_release.version)
            release = repo.get_release(github_release.version)
            # print("release.published_at", release.published_at)
            return release.published_at
        else:
            tags = repo.get_tags()
            current_metadata_tag_commit_date = ''
            for tag in tags.reversed:
                # print("tag.name: ",version.parse(tag.name))
                # print("github_release.version",github_release.version)
                if tag.name == github_release.version:
                    # return tag.commit.commit.committer.date
                    current_metadata_tag_commit_date = tag.commit.commit.committer.date
                if not (version.parse(tag.name).is_prerelease) and version.parse(
                    tag.name
                ) > version.parse(github_release.version):
                    print(
                        Fore.YELLOW
                        + f'*WARNING* {repo.name} has a newer release than {github_release.version}@<{current_metadata_tag_commit_date}>: '
                        f'{tag.name}@<{tag.commit.commit.committer.date}>'
                        + Style.RESET_ALL
                    )
            return current_metadata_tag_commit_date
        return None

I need to fixup my commit checking and remove the debug and will put in a PR for this (and fix the many incorrect non-UTC dates in bazel/repository_locations.bzl

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Apr 13, 2021

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Apr 13, 2021
@htuch htuch merged commit 542f7df into envoyproxy:main Apr 13, 2021
@htuch htuch deleted the libcurl-bump branch April 13, 2021 01:58
@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented Apr 13, 2021

I need to fixup my commit checking and remove the debug and will put in a PR for this (and fix the many incorrect non-UTC dates in bazel/repository_locations.bzl

I'd noticed that some time ago, but we frequently include-by-tag, so that has to be retained (in addition to, if not in place of.)

Thanks for looking more closely at this, getting this to UTC will be a big help.

Monkeyanator pushed a commit to Monkeyanator/envoy that referenced this pull request Apr 20, 2021
Also fix CPE to point at libcurl rather than curl.

Signed-off-by: Harvey Tuch <htuch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants