deps: update libcurl to 7.76.0.#15925
Conversation
Also fix CPE to point at libcurl rather than curl. Signed-off-by: Harvey Tuch <htuch@google.com>
|
@wrowe can you take a look at this from patch perspective? |
wrowe
left a comment
There was a problem hiding this comment.
LGTM, need to see CI results.
|
/lgtm deps |
|
@htuch it's on you to bump the date back one day |
Signed-off-by: Harvey Tuch <htuch@google.com>
|
The way the release date is retrieved today at https://github.com/envoyproxy/envoy/blob/main/tools/dependency/release_dates.py#L58-L69 is incorrect. It says the release date is the that of the latest commit. However releases can be cut at times later than the last commit and this release date is what is shown in the UI. For this curl release the actual UTC release date is Here is my code that makes a different API call to get the actual UTC release date: # Extract release date from GitHub API.
def get_release_date(repo, metadata_version, github_release):
if github_release.tagged:
try:
latest = repo.get_latest_release()
except github.GithubException as e:
# print(Fore.RED + 'GitHub API status get_latest_release(): {}'.format(str(e)) + Style.RESET_ALL)
latest = ''
pass
if latest and (github_release.version <= latest.tag_name):
# print("latest.tag_name: ", latest.tag_name)
# print("github_release.version: ", github_release.version)
release = repo.get_release(github_release.version)
# print("release.published_at", release.published_at)
return release.published_at
else:
tags = repo.get_tags()
current_metadata_tag_commit_date = ''
for tag in tags.reversed:
# print("tag.name: ",version.parse(tag.name))
# print("github_release.version",github_release.version)
if tag.name == github_release.version:
# return tag.commit.commit.committer.date
current_metadata_tag_commit_date = tag.commit.commit.committer.date
if not (version.parse(tag.name).is_prerelease) and version.parse(
tag.name
) > version.parse(github_release.version):
print(
Fore.YELLOW
+ f'*WARNING* {repo.name} has a newer release than {github_release.version}@<{current_metadata_tag_commit_date}>: '
f'{tag.name}@<{tag.commit.commit.committer.date}>'
+ Style.RESET_ALL
)
return current_metadata_tag_commit_date
return NoneI need to fixup my commit checking and remove the debug and will put in a PR for this (and fix the many incorrect non-UTC dates in |
|
/lgtm deps |
I'd noticed that some time ago, but we frequently include-by-tag, so that has to be retained (in addition to, if not in place of.) Thanks for looking more closely at this, getting this to UTC will be a big help. |
Also fix CPE to point at libcurl rather than curl. Signed-off-by: Harvey Tuch <htuch@google.com>
Also fix CPE to point at libcurl rather than curl.
Signed-off-by: Harvey Tuch htuch@google.com