docs: remove unsupported regex path matching notice#15916
docs: remove unsupported regex path matching notice#15916htuch merged 3 commits intoenvoyproxy:mainfrom
Conversation
…pporting Signed-off-by: Keerthan Ekbote <saiskee@gmail.com>
|
Hi @saiskee, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Keerthan Ekbote <saiskee@gmail.com>
| don’t recommend regex/slug routing at the reverse proxy level, however we may add support in the | ||
| future depending on demand. | ||
| * Prefix and exact path matching rules (both :ref:`case sensitive <envoy_v3_api_field_config.route.v3.RouteMatch.case_sensitive>` and case insensitive). | ||
| * :ref:`Regex path matching <envoy_v3_api_field_config.route.v3.RouteMatch.safe_regex` rules. |
There was a problem hiding this comment.
hi @saiskee the PR is failing due to trailing whitespace, could you clean up and push again
There was a problem hiding this comment.
its also failing due to missing closing bracket
undefined label: regex path matching <envoy_v3_api_field_config.route.v3.routematch.safe_regex
There was a problem hiding this comment.
Thanks @phlax, are there any tools for formatting docs similar to clang?
There was a problem hiding this comment.
im working on it right now
the first issue would be picked up by running ./tools/code_format/glint.sh
unfortunately with the second issue i think you would actually need to build the docs at least atm - im working on adding rstcheck which i would hope to pick it up - not 100% sure tho
There was a problem hiding this comment.
re the first issue - i would recommend setting your editor to automatically fixing the problems that ./glint.sh picks up, ie
- no trailing whitespace
- newline (not blank line) at end of all files
- no mixed tab and space indents
There was a problem hiding this comment.
re IDE auto fixing problems - Do I need an extension for this? I am using VsCode.
There was a problem hiding this comment.
Signed-off-by: Keerthan Ekbote <saiskee@gmail.com>
Signed-off-by: Keerthan Ekbote <saiskee@gmail.com> Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Signed-off-by: Keerthan Ekbote <saiskee@gmail.com>
Signed-off-by: Keerthan Ekbote saiskee@gmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Remove old message from http routing intro docs saying that regex path matching isn't supported.
Additional Description: Adds additional note linking to regex path matching.
Risk Level: low
Testing: N/A
Docs Changes: Adds additional note linking to regex path matching.
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]